qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Javier Celaya <javier.celaya@flexvm.es>
To: Christophe Fergeau <cfergeau@redhat.com>
Cc: spice-devel <spice-devel@lists.freedesktop.org>,
	Gerd Hoffmann <kraxel@redhat.com>,
	qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
	devel@flexvm.es
Subject: Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE
Date: Fri, 23 Jan 2015 15:06:07 +0100	[thread overview]
Message-ID: <17343709.DGNVESbVIr@javinlg> (raw)
In-Reply-To: <20150120160807.GM8982@edamame.cdg.redhat.com>

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

Hello, this is the patch with the version check. Christophe, can you check 
that the version is the correct one?

El Martes, 20 de enero de 2015 17:08:07 Christophe Fergeau escribió:
> Hey,
> 
> Version check seems good, we probably can raise spice-server version in
> git preemptively so that you can have a working version check now.
> 
> Given that lz4 support is optional, spice_server_set_image_compression
> should probably error out if we try to set lz4 but it's not supported.

Ack

> 
> Christophe

[-- Attachment #2: 0001-Add-lz4-compression-option-for-SPICE.patch --]
[-- Type: text/x-patch, Size: 969 bytes --]

>From 896a3ea776ee95653a7cb8a0c90111a89b57c73f Mon Sep 17 00:00:00 2001
From: Javier Celaya <javier.celaya@flexvm.es>
Date: Wed, 7 Jan 2015 11:53:24 +0100
Subject: [PATCH] Add lz4 compression option for SPICE.

Recently, SPICE included the lz4 compression algorithm. This patch adds
a command line option to select it.
---
 ui/spice-core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ui/spice-core.c b/ui/spice-core.c
index 6467fa4..dadcae9 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -359,6 +359,9 @@ static const char *compression_names[] = {
     [ SPICE_IMAGE_COMPRESS_QUIC ]     = "quic",
     [ SPICE_IMAGE_COMPRESS_GLZ ]      = "glz",
     [ SPICE_IMAGE_COMPRESS_LZ ]       = "lz",
+#if SPICE_SERVER_VERSION >= 0x000c07
+    [ SPICE_IMAGE_COMPRESS_LZ4 ]      = "lz4",
+#endif
 };
 #define parse_compression(_name)                                        \
     parse_name(_name, "image compression",                              \
-- 
1.9.3


  reply	other threads:[~2015-01-23 14:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08 10:50 [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE Javier Celaya
2015-01-08 11:28 ` Gerd Hoffmann
2015-01-08 11:48 ` [Qemu-devel] [Spice-devel] " Fabio Fantoni
2015-01-08 12:00   ` Javier Celaya
2015-01-20 16:08 ` Christophe Fergeau
2015-01-23 14:06   ` Javier Celaya [this message]
2015-01-23 16:25     ` Eric Blake
2015-01-26  8:48       ` Javier Celaya
2015-01-26 16:25         ` Eric Blake
2015-01-27  8:26           ` Markus Armbruster
2015-01-28 16:54             ` Javier Celaya
2015-01-28 19:08               ` Markus Armbruster
2015-07-24 14:12             ` Fabio Fantoni
2015-07-27  6:12               ` Markus Armbruster
2015-10-09  6:45             ` Fabio Fantoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17343709.DGNVESbVIr@javinlg \
    --to=javier.celaya@flexvm.es \
    --cc=aliguori@amazon.com \
    --cc=cfergeau@redhat.com \
    --cc=devel@flexvm.es \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=spice-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).