From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEesi-0000mG-Je for qemu-devel@nongnu.org; Fri, 23 Jan 2015 09:06:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEesf-0006UN-Ba for qemu-devel@nongnu.org; Fri, 23 Jan 2015 09:06:40 -0500 Received: from mail.nologin.es ([62.82.228.235]:39687 helo=nologin.es) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEesf-0006Rq-4T for qemu-devel@nongnu.org; Fri, 23 Jan 2015 09:06:37 -0500 From: Javier Celaya Date: Fri, 23 Jan 2015 15:06:07 +0100 Message-ID: <17343709.DGNVESbVIr@javinlg> In-Reply-To: <20150120160807.GM8982@edamame.cdg.redhat.com> References: <1508539.cfTQauU1Ry@javinlg> <20150120160807.GM8982@edamame.cdg.redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart15628593.8pAA4pfCjp" Content-Transfer-Encoding: 7Bit Subject: Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christophe Fergeau Cc: spice-devel , Gerd Hoffmann , qemu-devel@nongnu.org, Anthony Liguori , devel@flexvm.es This is a multi-part message in MIME format. --nextPart15628593.8pAA4pfCjp Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Hello, this is the patch with the version check. Christophe, can you ch= eck=20 that the version is the correct one? El Martes, 20 de enero de 2015 17:08:07 Christophe Fergeau escribi=F3: > Hey, >=20 > Version check seems good, we probably can raise spice-server version = in > git preemptively so that you can have a working version check now. >=20 > Given that lz4 support is optional, spice_server_set_image_compressio= n > should probably error out if we try to set lz4 but it's not supported= . Ack >=20 > Christophe --nextPart15628593.8pAA4pfCjp Content-Disposition: attachment; filename="0001-Add-lz4-compression-option-for-SPICE.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0001-Add-lz4-compression-option-for-SPICE.patch" >>From 896a3ea776ee95653a7cb8a0c90111a89b57c73f Mon Sep 17 00:00:00 2001 From: Javier Celaya Date: Wed, 7 Jan 2015 11:53:24 +0100 Subject: [PATCH] Add lz4 compression option for SPICE. Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select it. --- ui/spice-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/spice-core.c b/ui/spice-core.c index 6467fa4..dadcae9 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -359,6 +359,9 @@ static const char *compression_names[] = { [ SPICE_IMAGE_COMPRESS_QUIC ] = "quic", [ SPICE_IMAGE_COMPRESS_GLZ ] = "glz", [ SPICE_IMAGE_COMPRESS_LZ ] = "lz", +#if SPICE_SERVER_VERSION >= 0x000c07 + [ SPICE_IMAGE_COMPRESS_LZ4 ] = "lz4", +#endif }; #define parse_compression(_name) \ parse_name(_name, "image compression", \ -- 1.9.3 --nextPart15628593.8pAA4pfCjp--