From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Fam Zheng <famz@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] block: fix 'savevm' hang with -object iothread
Date: Wed, 17 May 2017 16:49:56 -0400 (EDT) [thread overview]
Message-ID: <1734615914.8716277.1495054196354.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170517170941.25850-1-stefanha@redhat.com>
----- Original Message -----
> From: "Stefan Hajnoczi" <stefanha@redhat.com>
> To: qemu-devel@nongnu.org
> Cc: "Kevin Wolf" <kwolf@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Fam Zheng" <famz@redhat.com>, "Stefan
> Hajnoczi" <stefanha@redhat.com>, qemu-block@nongnu.org
> Sent: Wednesday, May 17, 2017 7:09:38 PM
> Subject: [Qemu-devel] [PATCH 0/3] block: fix 'savevm' hang with -object iothread
>
> The 'savevm' command hangs when -object iothread is used. See patches for
> details, but basically the vmstate read/write code didn't conform to the
> latest block layer locking rules.
Thanks for the fixes.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Stefan Hajnoczi (3):
> block: count bdrv_co_rw_vmstate() requests
> block: use BDRV_POLL_WHILE() in bdrv_rw_vmstate()
> migration: avoid recursive AioContext locking in save_vmstate()
>
> block/io.c | 21 +++++++++++++--------
> migration/savevm.c | 12 +++++++++++-
> 2 files changed, 24 insertions(+), 9 deletions(-)
>
> --
> 2.9.3
>
>
>
prev parent reply other threads:[~2017-05-17 20:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 17:09 [Qemu-devel] [PATCH 0/3] block: fix 'savevm' hang with -object iothread Stefan Hajnoczi
2017-05-17 17:09 ` [Qemu-devel] [PATCH 1/3] block: count bdrv_co_rw_vmstate() requests Stefan Hajnoczi
2017-05-17 20:09 ` Eric Blake
2017-05-17 17:09 ` [Qemu-devel] [PATCH 2/3] block: use BDRV_POLL_WHILE() in bdrv_rw_vmstate() Stefan Hajnoczi
2017-05-17 20:16 ` Eric Blake
2017-05-17 20:47 ` Paolo Bonzini
2017-05-18 7:57 ` Kevin Wolf
2017-05-18 8:06 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-05-18 8:22 ` Kevin Wolf
2017-05-18 8:05 ` Stefan Hajnoczi
2017-05-17 17:09 ` [Qemu-devel] [PATCH 3/3] migration: avoid recursive AioContext locking in save_vmstate() Stefan Hajnoczi
2017-05-17 20:24 ` Eric Blake
2017-05-18 8:18 ` Kevin Wolf
2017-05-19 9:07 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-05-17 20:49 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1734615914.8716277.1495054196354.JavaMail.zimbra@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).