From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60643)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1T3Muj-00016T-Me
	for qemu-devel@nongnu.org; Mon, 20 Aug 2012 04:00:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1T3Mui-0004dE-56
	for qemu-devel@nongnu.org; Mon, 20 Aug 2012 04:00:45 -0400
Received: from mx4-phx2.redhat.com ([209.132.183.25]:46235)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1T3Muh-0004d6-SW
	for qemu-devel@nongnu.org; Mon, 20 Aug 2012 04:00:44 -0400
Date: Mon, 20 Aug 2012 04:00:41 -0400 (EDT)
From: Alon Levy <alevy@redhat.com>
Message-ID: <1740071682.16529215.1345449641615.JavaMail.root@redhat.com>
In-Reply-To: <5031D40C.8010602@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v7 1.2] qxl:
	add	QXL_IO_MONITORS_CONFIG_ASYNC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

> Hi,
> 
> >>> +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC
> >>> +#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0
> >>
> >> Just delete this and use
> >> defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC).
> > 
> > So you are telling me to undo a change that Gerd asked for - could
> > you
> > please at least debate about the merits of both approaches? the
> > point of
> > having QXL_HAS_IO_MONITORS_CONFIG_ASYNC always defined was to allow
> > usage of #if without defined, which is shorter.
> 
> Hmm?  That wasn't that I meant, must have been a tyops.
> I mean you should just do ...
> 
> #ifndef QXL_IO_MONITORS_CONFIG_ASYNC            <--- without *_HAS_*
> #define QXL_IO_MONITORS_CONFIG_ASYNC $value
> #endif
> 
> then you don't need QXL_HAS_IO_MONITORS_CONFIG_ASYNC (and all the
> #ifdefs) at all ...

So you want me to give the io a value - at this point I'd rather just add spice-protocol as a submodule, then we don't need to do any of this. How about it?

> 
> cheers,
>   Gerd
> 
> 
>