From: Steve Sistare <steven.sistare@oracle.com>
To: qemu-devel@nongnu.org
Cc: Alex Williamson <alex.williamson@redhat.com>,
Cedric Le Goater <clg@redhat.com>, Yi Liu <yi.l.liu@intel.com>,
Eric Auger <eric.auger@redhat.com>,
Zhenzhong Duan <zhenzhong.duan@intel.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>,
Steve Sistare <steven.sistare@oracle.com>
Subject: [PATCH V4 21/43] vfio/pci: vfio_notifier_init cpr parameters
Date: Thu, 29 May 2025 12:24:17 -0700 [thread overview]
Message-ID: <1748546679-154091-22-git-send-email-steven.sistare@oracle.com> (raw)
In-Reply-To: <1748546679-154091-1-git-send-email-steven.sistare@oracle.com>
Pass vdev and nr to vfio_notifier_init, for use by CPR in a subsequent
patch. No functional change.
Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
---
hw/vfio/pci.c | 31 +++++++++++++++++++------------
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index fa0601c..b776793 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -57,7 +57,8 @@ static void vfio_disable_interrupts(VFIOPCIDevice *vdev);
static void vfio_mmap_set_enabled(VFIOPCIDevice *vdev, bool enabled);
static void vfio_msi_disable_common(VFIOPCIDevice *vdev);
-static bool vfio_notifier_init(EventNotifier *e, const char *name, Error **errp)
+static bool vfio_notifier_init(VFIOPCIDevice *vdev, EventNotifier *e,
+ const char *name, int nr, Error **errp)
{
int ret = event_notifier_init(e, 0);
@@ -147,7 +148,7 @@ static bool vfio_intx_enable_kvm(VFIOPCIDevice *vdev, Error **errp)
pci_irq_deassert(&vdev->pdev);
/* Get an eventfd for resample/unmask */
- if (!vfio_notifier_init(&vdev->intx.unmask, "intx-unmask", errp)) {
+ if (!vfio_notifier_init(vdev, &vdev->intx.unmask, "intx-unmask", 0, errp)) {
goto fail;
}
@@ -300,7 +301,8 @@ static bool vfio_intx_enable(VFIOPCIDevice *vdev, Error **errp)
}
#endif
- if (!vfio_notifier_init(&vdev->intx.interrupt, "intx-interrupt", errp)) {
+ if (!vfio_notifier_init(vdev, &vdev->intx.interrupt, "intx-interrupt", 0,
+ errp)) {
return false;
}
fd = event_notifier_get_fd(&vdev->intx.interrupt);
@@ -486,7 +488,8 @@ static void vfio_connect_kvm_msi_virq(VFIOMSIVector *vector, int nr)
return;
}
- if (!vfio_notifier_init(&vector->kvm_interrupt, name, NULL)) {
+ if (!vfio_notifier_init(vector->vdev, &vector->kvm_interrupt, name, nr,
+ NULL)) {
goto fail_notifier;
}
@@ -525,12 +528,13 @@ static void vfio_pci_vector_init(VFIOPCIDevice *vdev, int nr)
{
VFIOMSIVector *vector = &vdev->msi_vectors[nr];
PCIDevice *pdev = &vdev->pdev;
- Error *err = NULL;
+ Error *local_err = NULL;
vector->vdev = vdev;
vector->virq = -1;
- if (!vfio_notifier_init(&vector->interrupt, "interrupt", &err)) {
- error_report_err(err);
+ if (!vfio_notifier_init(vdev, &vector->interrupt, "interrupt", nr,
+ &local_err)) {
+ error_report_err(local_err);
}
vector->use = true;
if (vdev->interrupt == VFIO_INT_MSIX) {
@@ -760,14 +764,15 @@ retry:
for (i = 0; i < vdev->nr_vectors; i++) {
VFIOMSIVector *vector = &vdev->msi_vectors[i];
- Error *err = NULL;
+ Error *local_err = NULL;
vector->vdev = vdev;
vector->virq = -1;
vector->use = true;
- if (!vfio_notifier_init(&vector->interrupt, "interrupt", &err)) {
- error_report_err(err);
+ if (!vfio_notifier_init(vdev, &vector->interrupt, "interrupt", i,
+ &local_err)) {
+ error_report_err(local_err);
}
qemu_set_fd_handler(event_notifier_get_fd(&vector->interrupt),
@@ -2919,7 +2924,8 @@ static void vfio_register_err_notifier(VFIOPCIDevice *vdev)
return;
}
- if (!vfio_notifier_init(&vdev->err_notifier, "err_notifier", &err)) {
+ if (!vfio_notifier_init(vdev, &vdev->err_notifier, "err_notifier", 0,
+ &err)) {
error_report_err(err);
vdev->pci_aer = false;
return;
@@ -2986,7 +2992,8 @@ static void vfio_register_req_notifier(VFIOPCIDevice *vdev)
return;
}
- if (!vfio_notifier_init(&vdev->req_notifier, "req_notifier", &err)) {
+ if (!vfio_notifier_init(vdev, &vdev->req_notifier, "req_notifier", 0,
+ &err)) {
error_report_err(err);
return;
}
--
1.8.3.1
next prev parent reply other threads:[~2025-05-29 19:30 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 19:23 [PATCH V4 00/43] Live update: vfio and iommufd Steve Sistare
2025-05-29 19:23 ` [PATCH V4 01/43] MAINTAINERS: Add reviewer for CPR Steve Sistare
2025-05-29 19:23 ` [PATCH V4 02/43] vfio: return mr from vfio_get_xlat_addr Steve Sistare
2025-06-03 10:39 ` Duan, Zhenzhong
2025-05-29 19:23 ` [PATCH V4 03/43] vfio/container: pass MemoryRegion to DMA operations Steve Sistare
2025-06-03 10:39 ` Duan, Zhenzhong
2025-05-29 19:24 ` [PATCH V4 04/43] vfio/pci: vfio_pci_put_device on failure Steve Sistare
2025-06-03 10:40 ` Duan, Zhenzhong
2025-06-03 14:09 ` Steven Sistare
2025-06-04 3:55 ` Duan, Zhenzhong
2025-06-04 13:33 ` Steven Sistare
2025-06-05 3:02 ` Duan, Zhenzhong
2025-06-05 15:16 ` Steven Sistare
2025-06-05 21:14 ` Cédric Le Goater
2025-05-29 19:24 ` [PATCH V4 05/43] migration: cpr helpers Steve Sistare
2025-05-29 19:24 ` [PATCH V4 06/43] migration: lower handler priority Steve Sistare
2025-05-29 19:24 ` [PATCH V4 07/43] vfio: vfio_find_ram_discard_listener Steve Sistare
2025-06-03 10:59 ` Duan, Zhenzhong
2025-05-29 19:24 ` [PATCH V4 08/43] vfio: move vfio-cpr.h Steve Sistare
2025-06-03 11:01 ` Duan, Zhenzhong
2025-05-29 19:24 ` [PATCH V4 09/43] vfio/container: register container for cpr Steve Sistare
2025-06-01 15:21 ` Cédric Le Goater
2025-06-03 11:57 ` Duan, Zhenzhong
2025-06-03 14:09 ` Steven Sistare
2025-06-03 14:17 ` Steven Sistare
2025-06-03 15:27 ` Cédric Le Goater
2025-05-29 19:24 ` [PATCH V4 10/43] vfio/container: preserve descriptors Steve Sistare
2025-06-01 16:57 ` Cédric Le Goater
2025-06-03 11:57 ` Duan, Zhenzhong
2025-05-29 19:24 ` [PATCH V4 11/43] vfio/container: discard old DMA vaddr Steve Sistare
2025-05-29 19:24 ` [PATCH V4 12/43] vfio/container: restore " Steve Sistare
2025-06-01 16:48 ` Cédric Le Goater
2025-05-29 19:24 ` [PATCH V4 13/43] vfio/container: mdev cpr blocker Steve Sistare
2025-05-29 19:24 ` [PATCH V4 14/43] vfio/container: recover from unmap-all-vaddr failure Steve Sistare
2025-05-29 19:24 ` [PATCH V4 15/43] pci: export msix_is_pending Steve Sistare
2025-05-29 19:24 ` [PATCH V4 16/43] pci: skip reset during cpr Steve Sistare
2025-06-01 16:38 ` Cédric Le Goater
2025-06-01 19:07 ` Michael S. Tsirkin
2025-06-02 12:36 ` Steven Sistare
2025-06-04 7:09 ` Cédric Le Goater
2025-06-04 11:59 ` Cédric Le Goater
2025-06-04 13:15 ` Steven Sistare
2025-06-04 13:48 ` Cédric Le Goater
2025-06-10 16:31 ` Michael S. Tsirkin
2025-06-10 17:05 ` Steven Sistare
2025-06-10 17:11 ` Cédric Le Goater
2025-06-10 17:14 ` Steven Sistare
2025-06-10 17:19 ` Cédric Le Goater
2025-06-10 17:09 ` Cédric Le Goater
2025-05-29 19:24 ` [PATCH V4 17/43] vfio-pci: " Steve Sistare
2025-06-01 16:39 ` Cédric Le Goater
2025-05-29 19:24 ` [PATCH V4 18/43] vfio/pci: vfio_pci_vector_init Steve Sistare
2025-06-01 15:25 ` Cédric Le Goater
2025-05-29 19:24 ` [PATCH V4 19/43] vfio/pci: vfio_notifier_init Steve Sistare
2025-05-29 19:24 ` [PATCH V4 20/43] vfio/pci: pass vector to virq functions Steve Sistare
2025-05-29 19:24 ` Steve Sistare [this message]
2025-05-29 19:24 ` [PATCH V4 22/43] vfio/pci: vfio_notifier_cleanup Steve Sistare
2025-05-29 19:24 ` [PATCH V4 23/43] vfio/pci: export MSI functions Steve Sistare
2025-06-01 15:27 ` Cédric Le Goater
2025-05-29 19:24 ` [PATCH V4 24/43] vfio-pci: preserve MSI Steve Sistare
2025-05-29 19:24 ` [PATCH V4 25/43] vfio-pci: preserve INTx Steve Sistare
2025-05-29 19:24 ` [PATCH V4 26/43] migration: close kvm after cpr Steve Sistare
2025-05-29 19:24 ` [PATCH V4 27/43] migration: cpr_get_fd_param helper Steve Sistare
2025-05-29 19:24 ` [PATCH V4 28/43] backends/iommufd: iommufd_backend_map_file_dma Steve Sistare
2025-05-29 19:24 ` [PATCH V4 29/43] backends/iommufd: change process ioctl Steve Sistare
2025-05-29 19:24 ` [PATCH V4 30/43] physmem: qemu_ram_get_fd_offset Steve Sistare
2025-05-29 19:24 ` [PATCH V4 31/43] vfio/iommufd: use IOMMU_IOAS_MAP_FILE Steve Sistare
2025-05-29 19:24 ` [PATCH V4 32/43] vfio/iommufd: invariant device name Steve Sistare
2025-06-10 6:10 ` Cédric Le Goater
2025-05-29 19:24 ` [PATCH V4 33/43] vfio/iommufd: add vfio_device_free_name Steve Sistare
2025-06-10 6:12 ` Cédric Le Goater
2025-05-29 19:24 ` [PATCH V4 34/43] vfio/iommufd: device name blocker Steve Sistare
2025-05-29 19:24 ` [PATCH V4 35/43] vfio/iommufd: register container for cpr Steve Sistare
2025-06-09 20:30 ` Cédric Le Goater
2025-06-09 20:47 ` Steven Sistare
2025-06-10 6:11 ` Cédric Le Goater
2025-05-29 19:24 ` [PATCH V4 36/43] migration: vfio cpr state hook Steve Sistare
2025-06-10 6:14 ` Cédric Le Goater
2025-05-29 19:24 ` [PATCH V4 37/43] vfio/iommufd: cpr state Steve Sistare
2025-05-29 19:24 ` [PATCH V4 38/43] vfio/iommufd: preserve descriptors Steve Sistare
2025-05-29 19:24 ` [PATCH V4 39/43] vfio/iommufd: reconstruct device Steve Sistare
2025-05-29 19:24 ` [PATCH V4 40/43] vfio/iommufd: reconstruct hwpt Steve Sistare
2025-05-29 19:24 ` [PATCH V4 41/43] vfio/iommufd: change process Steve Sistare
2025-05-29 19:24 ` [PATCH V4 42/43] iommufd: preserve DMA mappings Steve Sistare
2025-05-29 19:24 ` [PATCH V4 43/43] vfio/container: delete old cpr register Steve Sistare
2025-06-10 6:14 ` Cédric Le Goater
2025-06-01 17:26 ` [PATCH V4 00/43] Live update: vfio and iommufd Cédric Le Goater
2025-06-02 12:42 ` Steven Sistare
2025-06-03 12:09 ` Duan, Zhenzhong
2025-06-03 14:09 ` Steven Sistare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1748546679-154091-22-git-send-email-steven.sistare@oracle.com \
--to=steven.sistare@oracle.com \
--cc=alex.williamson@redhat.com \
--cc=clg@redhat.com \
--cc=eric.auger@redhat.com \
--cc=farosas@suse.de \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yi.l.liu@intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).