From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] hw/arm/virt: Fix incorrect non-secure flash dtb node name
Date: Fri, 13 May 2022 08:35:27 -0700 [thread overview]
Message-ID: <174ce227-73e5-da2e-f448-37a12ef7147a@linaro.org> (raw)
In-Reply-To: <20220513131316.4081539-2-peter.maydell@linaro.org>
On 5/13/22 06:13, Peter Maydell wrote:
> In the virt board with secure=on we put two nodes in the dtb
> for flash devices: one for the secure-only flash, and one
> for the non-secure flash. We get the reg properties for these
> correct, but in the DT node name, which by convention includes
> the base address of devices, we used the wrong address. Fix it.
>
> Spotted by dtc, which will complain
> Warning (unique_unit_address): /flash@0: duplicate unit-address (also used in node /secflash@0)
> if you dump the dtb from QEMU with -machine dumpdtb=file.dtb
> and then decompile it with dtc.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> hw/arm/virt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-05-13 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 13:13 [PATCH 0/2] hw/arm/virt: fix dtb nits spotted by dtc Peter Maydell
2022-05-13 13:13 ` [PATCH 1/2] hw/arm/virt: Fix incorrect non-secure flash dtb node name Peter Maydell
2022-05-13 15:35 ` Richard Henderson [this message]
2022-05-13 13:13 ` [PATCH 2/2] hw/arm/virt: Drop #size-cells and #address-cells from gpio-keys dtb node Peter Maydell
2022-05-13 15:36 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174ce227-73e5-da2e-f448-37a12ef7147a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).