From: Richard Henderson <richard.henderson@linaro.org>
To: Xu Zou <sendtozouxu@gmail.com>, qemu-devel@nongnu.org
Cc: laurent@vivier.eu
Subject: Re: [PATCH] linux-user: Handle EXCP10_COPR properly for i386
Date: Mon, 12 Jul 2021 09:56:20 -0700 [thread overview]
Message-ID: <17510cb3-8f55-ca64-f050-330bd31ea404@linaro.org> (raw)
In-Reply-To: <20210514084619.129020-1-sendtozouxu@gmail.com>
On 5/14/21 1:46 AM, Xu Zou wrote:
> + case EXCP10_COPR:
> + si_code = 0;
> + status = env->fp_status.float_exception_flags;
> + if (status & float_flag_invalid) {
> + si_code = TARGET_FPE_FLTINV;
> + }
This isn't correct. You want the set of unmasked exceptions. But target/i386 is not
providing those. You need much more than this one patch to fixed unmasked exceptions.
r~
next prev parent reply other threads:[~2021-07-12 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 8:46 [PATCH] linux-user: Handle EXCP10_COPR properly for i386 Xu Zou
2021-07-12 16:56 ` Richard Henderson [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-05-24 7:44 Xu Zou
2021-05-14 9:23 邹旭
2021-05-21 3:04 ` 邹旭
2021-05-14 7:56 Xu Zou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17510cb3-8f55-ca64-f050-330bd31ea404@linaro.org \
--to=richard.henderson@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=sendtozouxu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).