qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Steve Sistare <steven.sistare@oracle.com>
To: qemu-devel@nongnu.org
Cc: Alex Williamson <alex.williamson@redhat.com>,
	Cedric Le Goater <clg@redhat.com>, Yi Liu <yi.l.liu@intel.com>,
	Eric Auger <eric.auger@redhat.com>,
	Zhenzhong Duan <zhenzhong.duan@intel.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>,
	Steve Sistare <steven.sistare@oracle.com>
Subject: [PATCH V6 18/21] vfio/iommufd: change process
Date: Wed,  2 Jul 2025 14:58:55 -0700	[thread overview]
Message-ID: <1751493538-202042-19-git-send-email-steven.sistare@oracle.com> (raw)
In-Reply-To: <1751493538-202042-1-git-send-email-steven.sistare@oracle.com>

Finish CPR by change the owning process of the iommufd device in
post load.

Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
---
 hw/vfio/cpr-iommufd.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/hw/vfio/cpr-iommufd.c b/hw/vfio/cpr-iommufd.c
index a72b68d..cbeab57 100644
--- a/hw/vfio/cpr-iommufd.c
+++ b/hw/vfio/cpr-iommufd.c
@@ -112,10 +112,40 @@ static bool vfio_cpr_supported(IOMMUFDBackend *be, Error **errp)
     return true;
 }
 
+static int iommufd_cpr_pre_save(void *opaque)
+{
+    IOMMUFDBackend *be = opaque;
+
+    /*
+     * The process has not changed yet, but proactively try the ioctl,
+     * and it will fail if any DMA mappings are not supported.
+     */
+    if (!iommufd_change_process_capable(be)) {
+        error_report("some memory regions do not support "
+                     "IOMMU_IOAS_CHANGE_PROCESS");
+        return -1;
+    }
+    return 0;
+}
+
+static int iommufd_cpr_post_load(void *opaque, int version_id)
+{
+     IOMMUFDBackend *be = opaque;
+     Error *local_err = NULL;
+
+     if (!iommufd_change_process(be, &local_err)) {
+        error_report_err(local_err);
+        return -1;
+     }
+     return 0;
+}
+
 static const VMStateDescription iommufd_cpr_vmstate = {
     .name = "iommufd",
     .version_id = 0,
     .minimum_version_id = 0,
+    .pre_save = iommufd_cpr_pre_save,
+    .post_load = iommufd_cpr_post_load,
     .needed = cpr_incoming_needed,
     .fields = (VMStateField[]) {
         VMSTATE_END_OF_LIST()
-- 
1.8.3.1



  parent reply	other threads:[~2025-07-02 22:02 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02 21:58 [PATCH V6 00/21] Live update: vfio and iommufd Steve Sistare
2025-07-02 21:58 ` [PATCH V6 01/21] vfio-pci: preserve MSI Steve Sistare
2025-07-03  6:13   ` Cédric Le Goater
2025-07-02 21:58 ` [PATCH V6 02/21] vfio-pci: preserve INTx Steve Sistare
2025-07-03  6:13   ` Cédric Le Goater
2025-07-02 21:58 ` [PATCH V6 03/21] migration: close kvm after cpr Steve Sistare
2025-07-02 22:05   ` Steven Sistare
2025-07-04  9:50     ` Duan, Zhenzhong
2025-07-07 13:07       ` Steven Sistare
2025-07-08  3:04         ` Duan, Zhenzhong
2025-07-02 21:58 ` [PATCH V6 04/21] migration: cpr_get_fd_param helper Steve Sistare
2025-07-02 21:58 ` [PATCH V6 05/21] backends/iommufd: iommufd_backend_map_file_dma Steve Sistare
2025-07-02 21:58 ` [PATCH V6 06/21] backends/iommufd: change process ioctl Steve Sistare
2025-07-02 21:58 ` [PATCH V6 07/21] physmem: qemu_ram_get_fd_offset Steve Sistare
2025-07-02 21:58 ` [PATCH V6 08/21] vfio/iommufd: use IOMMU_IOAS_MAP_FILE Steve Sistare
2025-07-02 21:58 ` [PATCH V6 09/21] vfio/iommufd: invariant device name Steve Sistare
2025-07-02 21:58 ` [PATCH V6 10/21] vfio/iommufd: add vfio_device_free_name Steve Sistare
2025-07-02 21:58 ` [PATCH V6 11/21] vfio/iommufd: device name blocker Steve Sistare
2025-07-02 21:58 ` [PATCH V6 12/21] vfio/iommufd: register container for cpr Steve Sistare
2025-07-03  2:42   ` Duan, Zhenzhong
2025-07-02 21:58 ` [PATCH V6 13/21] migration: vfio cpr state hook Steve Sistare
2025-07-03  2:44   ` Duan, Zhenzhong
2025-07-02 21:58 ` [PATCH V6 14/21] vfio/iommufd: cpr state Steve Sistare
2025-07-02 21:58 ` [PATCH V6 15/21] vfio/iommufd: preserve descriptors Steve Sistare
2025-07-02 21:58 ` [PATCH V6 16/21] vfio/iommufd: reconstruct device Steve Sistare
2025-07-02 21:58 ` [PATCH V6 17/21] vfio/iommufd: reconstruct hwpt Steve Sistare
2025-07-02 21:58 ` Steve Sistare [this message]
2025-07-02 21:58 ` [PATCH V6 19/21] iommufd: preserve DMA mappings Steve Sistare
2025-07-02 21:58 ` [PATCH V6 20/21] vfio/container: delete old cpr register Steve Sistare
2025-07-02 21:58 ` [PATCH V6 21/21] vfio: doc changes for cpr Steve Sistare
2025-07-03  6:22 ` [PATCH V6 00/21] Live update: vfio and iommufd Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1751493538-202042-19-git-send-email-steven.sistare@oracle.com \
    --to=steven.sistare@oracle.com \
    --cc=alex.williamson@redhat.com \
    --cc=clg@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=farosas@suse.de \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yi.l.liu@intel.com \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).