From: Steve Sistare <steven.sistare@oracle.com>
To: qemu-devel@nongnu.org
Cc: Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>,
Hamza Khan <hamza.khan@nutanix.com>,
Steve Sistare <steven.sistare@oracle.com>
Subject: [RFC V2 2/8] migration: cpr setup notifier
Date: Thu, 17 Jul 2025 11:39:22 -0700 [thread overview]
Message-ID: <1752777568-236368-3-git-send-email-steven.sistare@oracle.com> (raw)
In-Reply-To: <1752777568-236368-1-git-send-email-steven.sistare@oracle.com>
Call MIG_EVENT_PRECOPY_SETUP earlier, before CPR starts. An early notifier
is needed for resetting vhost devices, as explained in the next patch.
Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
---
migration/migration.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 2efe60a..49d1e7d 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2259,7 +2259,14 @@ void qmp_migrate(const char *uri, bool has_channels,
stopped = true;
}
+ /* Notify before starting migration thread, and before starting cpr */
+ if (!resume_requested &&
+ migration_call_notifiers(s, MIG_EVENT_PRECOPY_SETUP, &local_err)) {
+ goto out;
+ }
+
if (cpr_state_save(cpr_channel, &local_err)) {
+ migration_call_notifiers(s, MIG_EVENT_PRECOPY_FAILED, NULL);
goto out;
}
@@ -4010,11 +4017,6 @@ void migration_connect(MigrationState *s, Error *error_in)
} else {
/* This is a fresh new migration */
rate_limit = migrate_max_bandwidth();
-
- /* Notify before starting migration thread */
- if (migration_call_notifiers(s, MIG_EVENT_PRECOPY_SETUP, &local_err)) {
- goto fail;
- }
}
migration_rate_set(rate_limit);
--
1.8.3.1
next prev parent reply other threads:[~2025-07-17 20:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 18:39 [RFC V2 0/8] Live update: tap and vhost Steve Sistare
2025-07-17 18:39 ` [RFC V2 1/8] migration: stop vm earlier for cpr Steve Sistare
2025-07-17 18:39 ` Steve Sistare [this message]
2025-07-17 18:39 ` [RFC V2 3/8] vhost: reset vhost devices " Steve Sistare
2025-08-27 11:29 ` Vladimir Sementsov-Ogievskiy
2025-08-27 18:38 ` Steven Sistare
2025-07-17 18:39 ` [RFC V2 4/8] cpr: delete all fds Steve Sistare
2025-07-17 18:39 ` [RFC V2 5/8] Revert "vhost-backend: remove vhost_kernel_reset_device()" Steve Sistare
2025-08-22 18:26 ` Steven Sistare
2025-07-17 18:39 ` [RFC V2 6/8] tap: common return label Steve Sistare
2025-07-17 18:39 ` [RFC V2 7/8] tap: cpr support Steve Sistare
2025-07-17 18:39 ` [RFC V2 8/8] tap: postload fix for cpr Steve Sistare
2025-07-18 8:48 ` [RFC V2 0/8] Live update: tap and vhost Lei Yang
2025-07-18 17:31 ` Steven Sistare
2025-07-24 5:46 ` Lei Yang
2025-08-05 13:54 ` Fabiano Rosas
2025-08-05 19:53 ` Steven Sistare
2025-08-06 15:51 ` Peter Xu
2025-08-11 18:24 ` Steven Sistare
2025-08-23 21:53 ` Vladimir Sementsov-Ogievskiy
2025-08-28 15:48 ` Steven Sistare
2025-08-29 19:37 ` Steven Sistare
2025-09-01 11:44 ` Vladimir Sementsov-Ogievskiy
2025-09-02 15:33 ` Steven Sistare
2025-09-02 17:09 ` Vladimir Sementsov-Ogievskiy
2025-09-05 16:16 ` Peter Xu
2025-09-08 9:55 ` Vladimir Sementsov-Ogievskiy
2025-09-09 21:35 ` Vladimir Sementsov-Ogievskiy
2025-09-10 16:58 ` Peter Xu
2025-09-10 17:27 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1752777568-236368-3-git-send-email-steven.sistare@oracle.com \
--to=steven.sistare@oracle.com \
--cc=farosas@suse.de \
--cc=hamza.khan@nutanix.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).