From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34879)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bDtmA-0002yB-BJ
	for qemu-devel@nongnu.org; Fri, 17 Jun 2016 09:25:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bDtm8-0005D2-2J
	for qemu-devel@nongnu.org; Fri, 17 Jun 2016 09:25:33 -0400
References: <1466169069-29375-1-git-send-email-real@ispras.ru>
	<1466169069-29375-10-git-send-email-real@ispras.ru>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <17590346-c29a-0b2d-e4f7-ee090ccbcfc5@redhat.com>
Date: Fri, 17 Jun 2016 15:25:17 +0200
MIME-Version: 1.0
In-Reply-To: <1466169069-29375-10-git-send-email-real@ispras.ru>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/13] ICH9 SMB: make TYPE_ICH9_SMB_DEVICE
 macro public
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Efimov Vasily <real@ispras.ru>, qemu-devel@nongnu.org
Cc: John Snow <jsnow@redhat.com>, qemu-block@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Kirill Batuzov <batuzovk@ispras.ru>



On 17/06/2016 15:11, Efimov Vasily wrote:
> ICH9 SMB bridge can be created using qdev API despite existence of helper
> function. The type name is needed for such creation. Using a preprocessor
> alias instead the string type name itself is preferable.
> 
> The patch makes the alias accessible through the header.
> 
> Signed-off-by: Efimov Vasily <real@ispras.ru>
> ---
>  hw/i2c/smbus_ich9.c    | 1 -
>  include/hw/i386/ich9.h | 2 ++
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/i2c/smbus_ich9.c b/hw/i2c/smbus_ich9.c
> index 498f03e..48fab22 100644
> --- a/hw/i2c/smbus_ich9.c
> +++ b/hw/i2c/smbus_ich9.c
> @@ -35,7 +35,6 @@
>  
>  #include "hw/i386/ich9.h"
>  
> -#define TYPE_ICH9_SMB_DEVICE "ICH9 SMB"
>  #define ICH9_SMB_DEVICE(obj) \
>       OBJECT_CHECK(ICH9SMBState, (obj), TYPE_ICH9_SMB_DEVICE)
>  
> diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h
> index 88233c3..f1294bc 100644
> --- a/include/hw/i386/ich9.h
> +++ b/include/hw/i386/ich9.h
> @@ -208,6 +208,8 @@ Object *ich9_lpc_find(void);
>  
>  
>  /* D31:F3 SMBus controller */
> +#define TYPE_ICH9_SMB_DEVICE "ICH9 SMB"
> +
>  #define ICH9_A2_SMB_REVISION                    0x02
>  #define ICH9_SMB_PI                             0x00
>  
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>