From: Paolo Bonzini <pbonzini@redhat.com>
To: Frederic Konrad <fred.konrad@greensocs.com>
Cc: peter maydell <peter.maydell@linaro.org>,
mark burton <mark.burton@greensocs.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC] icount: warp in the main_loop.
Date: Fri, 4 Jul 2014 06:36:51 -0400 (EDT) [thread overview]
Message-ID: <1760091596.3547443.1404470211117.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <53B681D7.5020005@greensocs.com>
> Right, but when I put a timer eg on QEMU_VIRTUAL_CLOCK the guest is stuck.
> icount_warp_rt is not called neither qemu_clock_warp(..)..
It should be. timer_mod_ns -> timerlist_rearm -> qemu_clock_warp.
> So yes as you said seems a qemu_clock_warp is missing somewhere.
>
> Shouldn't icount_warp_rt called regularly to advance the time when the
> VCPU is not executing?
No, everything is done dynamically based on timer deadlines. Polling is bad. :)
Paolo
prev parent reply other threads:[~2014-07-04 10:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 16:13 [Qemu-devel] [RFC] icount: warp in the main_loop fred.konrad
2014-07-04 7:30 ` Frederic Konrad
2014-07-04 7:57 ` Paolo Bonzini
2014-07-04 10:28 ` Frederic Konrad
2014-07-04 10:36 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1760091596.3547443.1404470211117.JavaMail.zimbra@redhat.com \
--to=pbonzini@redhat.com \
--cc=fred.konrad@greensocs.com \
--cc=mark.burton@greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).