From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34679)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X30ra-0005LR-Av
	for qemu-devel@nongnu.org; Fri, 04 Jul 2014 06:37:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X30rU-0000mV-7W
	for qemu-devel@nongnu.org; Fri, 04 Jul 2014 06:37:06 -0400
Received: from mx6-phx2.redhat.com ([209.132.183.39]:55199)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X30rU-0000lX-0d
	for qemu-devel@nongnu.org; Fri, 04 Jul 2014 06:37:00 -0400
Date: Fri, 4 Jul 2014 06:36:51 -0400 (EDT)
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <1760091596.3547443.1404470211117.JavaMail.zimbra@redhat.com>
In-Reply-To: <53B681D7.5020005@greensocs.com>
References: <1404231220-17339-1-git-send-email-fred.konrad@greensocs.com>
	<53B65823.3050006@greensocs.com> <53B65E76.4040900@redhat.com>
	<53B681D7.5020005@greensocs.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] icount: warp in the main_loop.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Frederic Konrad <fred.konrad@greensocs.com>
Cc: peter maydell <peter.maydell@linaro.org>, mark burton <mark.burton@greensocs.com>, qemu-devel@nongnu.org


> Right, but when I put a timer eg on QEMU_VIRTUAL_CLOCK the guest is stuck.
> icount_warp_rt is not called neither qemu_clock_warp(..)..

It should be.  timer_mod_ns -> timerlist_rearm -> qemu_clock_warp.

> So yes as you said seems a qemu_clock_warp is missing somewhere.
> 
> Shouldn't icount_warp_rt called regularly to advance the time when the
> VCPU is not executing?

No, everything is done dynamically based on timer deadlines.  Polling is bad. :)

Paolo