From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58529)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pmoore@redhat.com>) id 1Vtg0x-0005O5-HA
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 11:00:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pmoore@redhat.com>) id 1Vtg0o-0007BT-Hy
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 10:59:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48580)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pmoore@redhat.com>) id 1Vtg0o-0007AA-9X
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 10:59:46 -0500
From: Paul Moore <pmoore@redhat.com>
Date: Thu, 19 Dec 2013 10:59:39 -0500
Message-ID: <1760470.zyZhY791DA@sifl>
In-Reply-To: <1387385291-7825-1-git-send-email-coreyb@linux.vnet.ibm.com>
References: <1387385291-7825-1-git-send-email-coreyb@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [Qemu-devel] [PATCH] seccomp: exit if seccomp_init() fails
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Corey Bryant <coreyb@linux.vnet.ibm.com>, otubo@linux.vnet.ibm.com
Cc: qemu-devel@nongnu.org, aliguori@amazon.com

On Wednesday, December 18, 2013 11:48:11 AM Corey Bryant wrote:
> This fixes a bug where we weren't exiting if seccomp_init() failed.
> 
> Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
> ---
>  qemu-seccomp.c | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Paul Moore <pmoore@redhat.com>
 
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index cf07869..b7c1253 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -231,6 +231,7 @@ int seccomp_start(void)
> 
>      ctx = seccomp_init(SCMP_ACT_KILL);
>      if (ctx == NULL) {
> +        rc = -1;
>          goto seccomp_return;
>      }

-- 
paul moore
security and virtualization @ redhat