From: Richard Henderson <richard.henderson@linaro.org>
To: Stephen Long <steplong@quicinc.com>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, apazos@quicinc.com
Subject: Re: [PATCH RFC 3/3] target/arm: Implement SVE2 FCVTXNT
Date: Tue, 16 Jun 2020 11:59:39 -0700 [thread overview]
Message-ID: <1760d76c-068c-4842-f5dc-5f4b3f3719cd@linaro.org> (raw)
In-Reply-To: <20200428174332.17162-4-steplong@quicinc.com>
On 4/28/20 10:43 AM, Stephen Long wrote:
> +void HELPER(sve2_fcvtxnt)(void *vd, void *vn, void *vg,
> + void *status, uint32_t desc)
> +{
> + set_float_rounding_mode(float_round_to_odd, status);
> + HELPER(sve2_fcvtnt_ds)(vd, vn, vg, status, desc);
> +}
This is incorrect, as it leaves the rounding mode set to odd.
I've adjusted trans_FCVTXNT to the existing do_frint_mode, which handles
switching to and back from a fixed rounding mode.
r~
next prev parent reply other threads:[~2020-06-16 19:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 17:43 [PATCH RFC 0/3] target/arm: Implement SVE2 fp conversion Stephen Long
2020-04-28 17:43 ` [PATCH RFC 1/3] target/arm: Implement SVE2 FCVTNT Stephen Long
2020-04-28 17:43 ` [PATCH RFC 2/3] target/arm: Implement SVE2 FCVTLT Stephen Long
2020-04-28 17:43 ` [PATCH RFC 3/3] target/arm: Implement SVE2 FCVTXNT Stephen Long
2020-06-16 18:59 ` Richard Henderson [this message]
2020-06-16 19:00 ` [PATCH RFC 0/3] target/arm: Implement SVE2 fp conversion Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1760d76c-068c-4842-f5dc-5f4b3f3719cd@linaro.org \
--to=richard.henderson@linaro.org \
--cc=apazos@quicinc.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steplong@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).