From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: Greg Kurz <groug@kaod.org>
Subject: Re: [PULL 0/8] 9p queue 2021-10-27
Date: Wed, 27 Oct 2021 16:05:39 +0200 [thread overview]
Message-ID: <1763549.VT83FdeJ1q@silver> (raw)
In-Reply-To: <cover.1635340713.git.qemu_oss@crudebyte.com>
On Mittwoch, 27. Oktober 2021 15:18:33 CEST Christian Schoenebeck wrote:
> The following changes since commit 931ce30859176f0f7daac6bac255dae5eb21284e:
>
> Merge remote-tracking branch 'remotes/dagrh/tags/pull-virtiofs-20211026'
> into staging (2021-10-26 07:38:41 -0700)
>
> are available in the Git repository at:
>
> https://github.com/cschoenebeck/qemu.git tags/pull-9p-20211027
>
> for you to fetch changes up to 7e985780aaab93d2c5be9b62d8d386568dfb071e:
>
> 9pfs: use P9Array in v9fs_walk() (2021-10-27 14:45:22 +0200)
>
> ----------------------------------------------------------------
> 9pfs: performance fix and cleanup
>
> * First patch fixes suboptimal I/O performance on guest due to previously
> incorrect block size being transmitted to 9p client.
>
> * Subsequent patches are cleanup ones intended to reduce code complexity.
>
> ----------------------------------------------------------------
> Christian Schoenebeck (8):
> 9pfs: fix wrong I/O block size in Rgetattr
> 9pfs: deduplicate iounit code
> 9pfs: simplify blksize_to_iounit()
> 9pfs: introduce P9Array
> fsdev/p9array.h: check scalar type in P9ARRAY_NEW()
> 9pfs: make V9fsString usable via P9Array API
> 9pfs: make V9fsPath usable via P9Array API
> 9pfs: use P9Array in v9fs_walk()
>
> fsdev/9p-marshal.c | 2 +
> fsdev/9p-marshal.h | 3 +
> fsdev/file-op-9p.h | 2 +
> fsdev/p9array.h | 160
> +++++++++++++++++++++++++++++++++++++++++++++++++++++ hw/9pfs/9p.c |
> 70 +++++++++++++----------
> 5 files changed, 208 insertions(+), 29 deletions(-)
> create mode 100644 fsdev/p9array.h
Regarding last 5 patches: Daniel raised a concern that not using g_autoptr
would deviate from current QEMU coding patterns:
https://lists.gnu.org/archive/html/qemu-devel/2021-10/msg00081.html
Unfortunately I saw no way to address his concern without adding unnecessary
code complexity, so I decided to make this a 9p local type (QArray -> P9Array)
for now, which can easily be replaced in future (e.g. when there will be
something appropriate on glib side).
Best regards,
Christian Schoenebeck
next prev parent reply other threads:[~2021-10-27 15:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 13:18 [PULL 0/8] 9p queue 2021-10-27 Christian Schoenebeck
2021-10-27 13:18 ` [PULL 6/8] 9pfs: make V9fsString usable via P9Array API Christian Schoenebeck
2021-10-27 13:18 ` [PULL 7/8] 9pfs: make V9fsPath " Christian Schoenebeck
2021-10-27 13:18 ` [PULL 4/8] 9pfs: introduce P9Array Christian Schoenebeck
2021-10-27 13:18 ` [PULL 3/8] 9pfs: simplify blksize_to_iounit() Christian Schoenebeck
2021-10-27 13:18 ` [PULL 8/8] 9pfs: use P9Array in v9fs_walk() Christian Schoenebeck
2021-10-27 13:18 ` [PULL 5/8] fsdev/p9array.h: check scalar type in P9ARRAY_NEW() Christian Schoenebeck
2021-10-27 13:18 ` [PULL 2/8] 9pfs: deduplicate iounit code Christian Schoenebeck
2021-10-27 13:18 ` [PULL 1/8] 9pfs: fix wrong I/O block size in Rgetattr Christian Schoenebeck
2021-10-27 14:05 ` Christian Schoenebeck [this message]
2021-10-27 15:36 ` [PULL 0/8] 9p queue 2021-10-27 Philippe Mathieu-Daudé
2021-10-27 16:21 ` Christian Schoenebeck
2021-10-27 16:48 ` Philippe Mathieu-Daudé
2021-10-27 17:29 ` Christian Schoenebeck
2021-10-27 18:11 ` Philippe Mathieu-Daudé
2021-10-27 18:44 ` Richard Henderson
2021-10-28 12:03 ` Christian Schoenebeck
2021-10-27 16:01 ` Greg Kurz
2021-10-27 21:03 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1763549.VT83FdeJ1q@silver \
--to=qemu_oss@crudebyte.com \
--cc=groug@kaod.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).