From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLFj3-00038m-0T for qemu-devel@nongnu.org; Wed, 05 Mar 2014 12:35:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLFit-0002nA-Nj for qemu-devel@nongnu.org; Wed, 05 Mar 2014 12:35:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLFit-0002lx-Ee for qemu-devel@nongnu.org; Wed, 05 Mar 2014 12:35:15 -0500 From: Paul Moore Date: Wed, 05 Mar 2014 12:35:10 -0500 Message-ID: <17650523.zQ4lDEmyid@sifl> In-Reply-To: <53173A86.8040206@linux.vnet.ibm.com> References: <20140226152501.5062.42074.stgit@localhost> <1422240.VnSJ3J12An@sifl> <53173A86.8040206@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [Qemu-devel] [PATCH] seccomp: add shmctl(), mlock(), and munlock() to the syscall whitelist List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Otubo Cc: qemu-devel@nongnu.org On Wednesday, March 05, 2014 11:53:58 AM Eduardo Otubo wrote: > On 03/03/2014 05:41 PM, Paul Moore wrote: > > On Wednesday, February 26, 2014 10:25:01 AM Paul Moore wrote: > >> Additional testing reveals that PulseAudio requires shmctl() and the > >> mlock()/munlock() syscalls on some systems/configurations. As before, > >> on systems that do require these syscalls, the problem can be seen with > >> > >> the following command line: > >> # qemu -monitor stdio -sandbox on \ > >> > >> -device intel-hda -device hda-duplex > >> > >> Signed-off-by: Paul Moore > >> --- > >> > >> qemu-seccomp.c | 5 ++++- > >> 1 file changed, 4 insertions(+), 1 deletion(-) > >> > >> diff --git a/qemu-seccomp.c b/qemu-seccomp.c > >> index caa926e..3db1e9b 100644 > >> --- a/qemu-seccomp.c > >> +++ b/qemu-seccomp.c > >> @@ -225,7 +225,10 @@ static const struct QemuSeccompSyscall > >> seccomp_whitelist[] = { { SCMP_SYS(fchmod), 240 }, > >> > >> { SCMP_SYS(shmget), 240 }, > >> { SCMP_SYS(shmat), 240 }, > >> > >> - { SCMP_SYS(shmdt), 240 } > >> + { SCMP_SYS(shmdt), 240 }, > >> + { SCMP_SYS(shmctl), 240 }, > >> + { SCMP_SYS(mlock), 240 }, > >> + { SCMP_SYS(munlock), 240 } > >> > >> }; > >> > >> int seccomp_start(void) > > > > Bump to bring this back the forefront of everyone's minds. Can we get > > this merged? > > Sorry for the late review, I've been hit by a terrible tendinitis and > was unable to use a computer for the last week. :( Hopefully nothing that isn't too unbearable and unmanageable. Tendinitis can be a real pain. > I ACK this patch and I'll create a pull request by friday EOD if nothing > else comes up. Great, thank you. I've run across one more issue related to Open vSwitch and getrusage(); I'll try to get that fixed/tested before Friday, but don't let that hold up this fix. On a somewhat related note, have you done any work on the dynamic, per-feature whitelist? I'm thinking of doing some work to put together a basic framework for this, but I didn't want to waste time on a duplicated effort ... -Paul -- paul moore security and virtualization @ redhat