From: Thomas Huth <thuth@redhat.com>
To: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')
Date: Wed, 23 Oct 2019 03:09:57 -0400 (EDT) [thread overview]
Message-ID: <1768294380.8112839.1571814597964.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAL1e-=ihiQiFptBKHyVEo_DZv5xHwa7eGuM7UFLo_c5DbYtxhA@mail.gmail.com>
----- Original Message -----
> From: "Aleksandar Markovic" <aleksandar.m.mail@gmail.com>
> Sent: Tuesday, October 22, 2019 10:35:51 PM
>
> On Tuesday, October 8, 2019, Thomas Huth <thuth@redhat.com> wrote:
>
> > When running "make distclean" we currently leave a lot of generated
> > files in the build directory. These should be completely removed.
> > Some of the generated files are removed in the "clean" target (which
> > is a prerequisite for the "distclean" target), since binary files
> > should be removed in this step already.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> > v2:
> > - Remove tests/qemu-iotests/common.env in "distclean", not in "clean"
> > - Improved patch description
> >
> > Makefile | 6 +++---
> > tests/Makefile.include | 12 +++++++++++-
> > 2 files changed, 14 insertions(+), 4 deletions(-)
> >
> > Hello, Thomas,
>
> Do you intend to send a new version of this patch?
>
> It looks to me this is a very nice clean up that definitely should go into
> 4.2, no?
I'm still planning to send a v3 of this patch, but currently I don't have time to work on this during the next two weeks. So this will likely miss the deadline for 4.2. Feel free to pick up my patch and send a fixed version if you think that this should still go into 4.2. Otherwise, I'll take care of it in 5.0.
Thomas
prev parent reply other threads:[~2019-10-23 7:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 8:28 [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean') Thomas Huth
2019-10-08 12:18 ` Aleksandar Markovic
2019-10-08 12:35 ` Thomas Huth
2019-10-08 12:41 ` Peter Maydell
2019-10-08 16:04 ` Paolo Bonzini
2020-06-13 16:28 ` Aleksandar Markovic
2020-06-15 5:17 ` Thomas Huth
2020-06-15 7:13 ` Paolo Bonzini
2020-06-15 7:46 ` Thomas Huth
2020-06-15 19:46 ` Markus Armbruster
2019-10-08 12:41 ` Daniel P. Berrangé
2019-10-08 13:34 ` Thomas Huth
2019-10-08 18:19 ` Markus Armbruster
2019-10-22 20:35 ` Aleksandar Markovic
2019-10-23 7:09 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1768294380.8112839.1571814597964.JavaMail.zimbra@redhat.com \
--to=thuth@redhat.com \
--cc=aleksandar.m.mail@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).