From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: luis.pires@eldorado.org.br, alex.bennee@linaro.org
Subject: Re: [PATCH] tcg: Extend call args using the correct opcodes
Date: Thu, 28 Oct 2021 20:59:51 +0200 [thread overview]
Message-ID: <176ab49f-53f9-b698-2ecd-6284891ff805@amsat.org> (raw)
In-Reply-To: <20211028184440.1508585-1-richard.henderson@linaro.org>
On 10/28/21 20:44, Richard Henderson wrote:
> Pretending that the source is i64 when it is in fact i32 is
> incorrect; we have type-changing opcodes that must be used.
> This bug trips up the subsequent change to the optimizer.
>
> Fixes: 4f2331e5b67a
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>
> This fixes a problem found in s390x host testing, and should
> be considered patch 41.5/51 in
>
> [PATCH v4 00/51] tcg: optimize redundant sign extensions
>
> just before
>
> tcg/optimize: Stop forcing z_mask to "garbage" for 32-bit values
>
>
> r~
>
> ---
> tcg/tcg.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2021-10-28 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 18:44 [PATCH] tcg: Extend call args using the correct opcodes Richard Henderson
2021-10-28 18:59 ` Philippe Mathieu-Daudé [this message]
2021-10-28 19:55 ` Luis Fernando Fujita Pires
2021-11-01 10:14 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176ab49f-53f9-b698-2ecd-6284891ff805@amsat.org \
--to=f4bug@amsat.org \
--cc=alex.bennee@linaro.org \
--cc=luis.pires@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).