qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH] 9pfs: disable msize warning for synth driver
Date: Mon, 07 Sep 2020 13:55:52 +0200	[thread overview]
Message-ID: <1773061.9aR6DczYlW@silver> (raw)
In-Reply-To: <20200907115758.70366924@bahia.lan>

On Montag, 7. September 2020 11:57:58 CEST Greg Kurz wrote:
> On Sun, 6 Sep 2020 18:50:32 +0200
> 
> Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> > Previous patch introduced a performance warning being logged on host
> > side if client connected with an 'msize' <= 8192. Disable this
> > performance warning for the synth driver to prevent that warning from
> > being printed whenever the 9pfs (qtest) test cases are running.
> > 
> > Introduce a new export flag V9FS_NO_PERF_WARN for that purpose, which
> > might also be used to disable such warnings from the CLI in future.
> > 
> > We could have also prevented the warning by simply raising P9_MAX_SIZE
> > in virtio-9p-test.c to any value larger than 8192, however in the
> > context of test cases it makes sense running for edge cases, which
> > includes the lowest 'msize' value supported by the server which is
> > 4096, hence we want to preserve an msize of 4096 for the test client.
> > 
> > Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> > ---
> 
> Heh, yes I guess it makes sense :)
> 
> I guess you could maybe queue this patch before the other one.
> 
> Reviewed-by: Greg Kurz <groug@kaod.org>

Thanks!

BTW, have you ever tried dealing with patchwork client's 'state' feature for 
already transmited patches on the list (new, rejected, etc.)?

Not that there were many 9p patches for actually needing that; just curious if 
that's an LKML only feature.

Best regards,
Christian Schoenebeck




  reply	other threads:[~2020-09-07 11:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-06 16:50 [PATCH] 9pfs: disable msize warning for synth driver Christian Schoenebeck
2020-09-07  9:57 ` [SPAM] " Greg Kurz
2020-09-07 11:55   ` Christian Schoenebeck [this message]
2020-09-07 12:27     ` Greg Kurz
2020-09-08  8:10       ` Greg Kurz
2020-09-08  9:01         ` Christian Schoenebeck
2020-09-08  9:34           ` Greg Kurz
2020-09-08 10:03             ` Christian Schoenebeck
2020-09-08 11:02               ` Christian Schoenebeck
2020-09-08  9:54           ` Christian Schoenebeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1773061.9aR6DczYlW@silver \
    --to=qemu_oss@crudebyte.com \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).