From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 497A3C5DF62 for ; Wed, 6 Nov 2019 10:20:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1661820869 for ; Wed, 6 Nov 2019 10:20:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1661820869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=proxmox.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSIQG-0002bi-Be for qemu-devel@archiver.kernel.org; Wed, 06 Nov 2019 05:20:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41562) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSIOj-00016N-VQ for qemu-devel@nongnu.org; Wed, 06 Nov 2019 05:18:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSIOj-0004Ut-3K for qemu-devel@nongnu.org; Wed, 06 Nov 2019 05:18:45 -0500 Received: from proxmox-new.maurer-it.com ([212.186.127.180]:37154) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iSIOb-0004QK-7o; Wed, 06 Nov 2019 05:18:37 -0500 Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 204B7457FF; Wed, 6 Nov 2019 11:18:28 +0100 (CET) Date: Wed, 6 Nov 2019 11:18:27 +0100 (CET) From: Dietmar Maurer To: Max Reitz , Stefan Hajnoczi Message-ID: <1775789152.22.1573035507302@webmail.proxmox.com> In-Reply-To: References: <1767781109.66.1572948164492@webmail.proxmox.com> <20191106083222.GA189998@stefanha-x1.localdomain> Subject: Re: backup_calculate_cluster_size does not consider source MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.2-Rev15 X-Originating-Client: open-xchange-appsuite X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.186.127.180 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Dietmar Maurer Cc: Kevin Wolf , "qemu-devel@nongnu.org" , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > The thing is, it just seems unnecessary to me to take the source cluster > size into account in general. It seems weird that a medium only allows > 4 MB reads, because, well, guests aren=E2=80=99t going to take that into = account. Maybe it is strange, but it is quite obvious that there is an optimal clust= er size for each storage type (4M in case of ceph)...