Re: [Qemu-devel] [PATCH 0/4 v2] target-i386: move tcg intialization inside CPU object

Re: [Qemu-devel] [PATCH 0/4 v2] target-i386: move tcg intialization inside CPU object

[Igor Mammedov]

On 06/28/2012 02:21 PM, Jan Kiszka wrote:
> On 2012-06-25 15:55, Igor Mammedov wrote:
>> v2:
>>    - drop usage of prev_debug_excp_handler consistently in all users
>>    - split from reset patches to avoid confusion of inter-dependency
>>
>> Compile & Run tested:
>>    target-i386: tcg and kvm mode
>>    i386-linux-user: running of /bin/ls
>> Compile tested:
>>    xtensa-softmmu && xtensaeb-softmmu
>>
>> git tree for testing:
>>    https://github.com/imammedo/qemu/tree/x86cpu_qom_tcg_v2
>>
>>
>> Igor Mammedov (4):
>>    target-i386: drop usage of prev_debug_excp_handler
>>    target-xtensa: drop usage of prev_debug_excp_handler
>>    cleanup cpu_set_debug_excp_handler
>>    target-i386: move tcg initialization into x86_cpu_initfn()
>>
>>   cpu-exec.c             |    5 +----
>>   exec-all.h             |    2 +-
>>   target-i386/cpu.c      |   10 ++++++++++
>>   target-i386/cpu.h      |    1 +
>>   target-i386/helper.c   |   16 +---------------
>>   target-xtensa/helper.c |    8 +-------
>>   6 files changed, 15 insertions(+), 27 deletions(-)
>>
>
> Looks good to me.
Thanks for reviews guys.

Jan,
I'm still learning about review process rules. Does usually or in your case "Looks good to me" implies Reviewed-By:... ?

And do I have to send pull request or ask somebody (whom?) to take patches in?

> Jan
>

-- 
-----
  Igor

Re: [Qemu-devel] [PATCH 0/4 v2] target-i386: move tcg intialization inside CPU object

[Igor Mammedov]

ping

On 06/25/2012 03:55 PM, Igor Mammedov wrote:
> v2:
>    - drop usage of prev_debug_excp_handler consistently in all users
>    - split from reset patches to avoid confusion of inter-dependency
>
> Compile & Run tested:
>    target-i386: tcg and kvm mode
>    i386-linux-user: running of /bin/ls
> Compile tested:
>    xtensa-softmmu && xtensaeb-softmmu
>
> git tree for testing:
>    https://github.com/imammedo/qemu/tree/x86cpu_qom_tcg_v2
>
>
> Igor Mammedov (4):
>    target-i386: drop usage of prev_debug_excp_handler
>    target-xtensa: drop usage of prev_debug_excp_handler
>    cleanup cpu_set_debug_excp_handler
>    target-i386: move tcg initialization into x86_cpu_initfn()
>
>   cpu-exec.c             |    5 +----
>   exec-all.h             |    2 +-
>   target-i386/cpu.c      |   10 ++++++++++
>   target-i386/cpu.h      |    1 +
>   target-i386/helper.c   |   16 +---------------
>   target-xtensa/helper.c |    8 +-------
>   6 files changed, 15 insertions(+), 27 deletions(-)
>

-- 
-----
  Igor

Re: [Qemu-devel] [PATCH 0/4 v2] target-i386: move tcg intialization inside CPU object

[Igor Mammedov]

ping.

On 06/25/2012 03:55 PM, Igor Mammedov wrote:
> v2:
>    - drop usage of prev_debug_excp_handler consistently in all users
>    - split from reset patches to avoid confusion of inter-dependency
>
> Compile & Run tested:
>    target-i386: tcg and kvm mode
>    i386-linux-user: running of /bin/ls
> Compile tested:
>    xtensa-softmmu && xtensaeb-softmmu
>
> git tree for testing:
>    https://github.com/imammedo/qemu/tree/x86cpu_qom_tcg_v2
>
>
> Igor Mammedov (4):
>    target-i386: drop usage of prev_debug_excp_handler
>    target-xtensa: drop usage of prev_debug_excp_handler
>    cleanup cpu_set_debug_excp_handler
>    target-i386: move tcg initialization into x86_cpu_initfn()
>
>   cpu-exec.c             |    5 +----
>   exec-all.h             |    2 +-
>   target-i386/cpu.c      |   10 ++++++++++
>   target-i386/cpu.h      |    1 +
>   target-i386/helper.c   |   16 +---------------
>   target-xtensa/helper.c |    8 +-------
>   6 files changed, 15 insertions(+), 27 deletions(-)
>

-- 
-----
  Igor

Re: [Qemu-devel] [PATCH 0/4 v2] target-i386: move tcg intialization inside CPU object

[Igor Mammedov]

Anthony,

ping

Is something wrong with this series?


PS:
Jan,
  may I ask for an explicit Acked-By, pls?

On 06/25/2012 03:55 PM, Igor Mammedov wrote:
> v2:
>    - drop usage of prev_debug_excp_handler consistently in all users
>    - split from reset patches to avoid confusion of inter-dependency
>
> Compile & Run tested:
>    target-i386: tcg and kvm mode
>    i386-linux-user: running of /bin/ls
> Compile tested:
>    xtensa-softmmu && xtensaeb-softmmu
>
> git tree for testing:
>    https://github.com/imammedo/qemu/tree/x86cpu_qom_tcg_v2
>
>
> Igor Mammedov (4):
>    target-i386: drop usage of prev_debug_excp_handler
>    target-xtensa: drop usage of prev_debug_excp_handler
>    cleanup cpu_set_debug_excp_handler
>    target-i386: move tcg initialization into x86_cpu_initfn()
>
>   cpu-exec.c             |    5 +----
>   exec-all.h             |    2 +-
>   target-i386/cpu.c      |   10 ++++++++++
>   target-i386/cpu.h      |    1 +
>   target-i386/helper.c   |   16 +---------------
>   target-xtensa/helper.c |    8 +-------
>   6 files changed, 15 insertions(+), 27 deletions(-)
>

Re: [Qemu-devel] [PATCH 0/4 v2] target-i386: move tcg intialization inside CPU object

[Igor Mammedov]

ping

----- Original Message -----
> From: "Igor Mammedov" <imammedo@redhat.com>
> To: qemu-devel@nongnu.org
> Cc: "peter maydell" <peter.maydell@linaro.org>, aliguori@us.ibm.com, ehabkost@redhat.com, sw@weilnetz.de,
> mtosatti@redhat.com, agraf@suse.de, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, jcmvbkbc@gmail.com,
> avi@redhat.com, "jan kiszka" <jan.kiszka@siemens.com>, afaerber@suse.de, rth@twiddle.net
> Sent: Monday, June 25, 2012 3:55:03 PM
> Subject: [Qemu-devel] [PATCH 0/4 v2] target-i386: move tcg intialization	inside CPU object
> 
> v2:
>   - drop usage of prev_debug_excp_handler consistently in all users
>   - split from reset patches to avoid confusion of inter-dependency
> 
> Compile & Run tested:
>   target-i386: tcg and kvm mode
>   i386-linux-user: running of /bin/ls
> Compile tested:
>   xtensa-softmmu && xtensaeb-softmmu
> 
> git tree for testing:
>   https://github.com/imammedo/qemu/tree/x86cpu_qom_tcg_v2
> 
> 
> Igor Mammedov (4):
>   target-i386: drop usage of prev_debug_excp_handler
>   target-xtensa: drop usage of prev_debug_excp_handler
>   cleanup cpu_set_debug_excp_handler
>   target-i386: move tcg initialization into x86_cpu_initfn()
> 
>  cpu-exec.c             |    5 +----
>  exec-all.h             |    2 +-
>  target-i386/cpu.c      |   10 ++++++++++
>  target-i386/cpu.h      |    1 +
>  target-i386/helper.c   |   16 +---------------
>  target-xtensa/helper.c |    8 +-------
>  6 files changed, 15 insertions(+), 27 deletions(-)
> 
> --
> 1.7.10.2
> 
> 
> 

Re: [Qemu-devel] [PATCH 1/4] target-i386: drop usage of prev_debug_excp_handler

[Andreas Färber]

Am 25.06.2012 15:55, schrieb Igor Mammedov:
> Chains of exception handlers are currently unused feature, drop it
> for now so as not to expose prev_debug_excp_handler at global
> scope when moving tcg initialization into target-i386/cpu.c
> 
> Later we probably could re-invent better interface for this.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>

FWIW,

Reviewed-by: Andreas Färber <afaerber@suse.de>

/-F

> ---
>  target-i386/helper.c |    7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/target-i386/helper.c b/target-i386/helper.c
> index 2cc8097..b9384f6 100644
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -941,8 +941,6 @@ int check_hw_breakpoints(CPUX86State *env, int force_dr6_update)
>      return hit_enabled;
>  }
>  
> -static CPUDebugExcpHandler *prev_debug_excp_handler;
> -
>  static void breakpoint_handler(CPUX86State *env)
>  {
>      CPUBreakpoint *bp;
> @@ -965,8 +963,6 @@ static void breakpoint_handler(CPUX86State *env)
>                  break;
>              }
>      }
> -    if (prev_debug_excp_handler)
> -        prev_debug_excp_handler(env);
>  }
>  
>  typedef struct MCEInjectionParams {
> @@ -1166,8 +1162,7 @@ X86CPU *cpu_x86_init(const char *cpu_model)
>          inited = 1;
>          optimize_flags_init();
>  #ifndef CONFIG_USER_ONLY
> -        prev_debug_excp_handler =
> -            cpu_set_debug_excp_handler(breakpoint_handler);
> +        cpu_set_debug_excp_handler(breakpoint_handler);
>  #endif
>      }
>      if (cpu_x86_register(cpu, cpu_model) < 0) {
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH 0/4 v2] target-i386: move tcg intialization inside CPU object

[Andreas Färber]

Am 08.08.2012 13:28, schrieb Igor Mammedov:
> ping

FWIW it looks to me as if Jan's previous review comments regarding
debug_excp_helper have been addressed. So if someone could take a look
at patch 3/4 and ack that we don't need chaining of handlers, this
should be good to go for 1.2.

Andreas

> 
> ----- Original Message -----
>> From: "Igor Mammedov" <imammedo@redhat.com>
>> To: qemu-devel@nongnu.org
>> Cc: "peter maydell" <peter.maydell@linaro.org>, aliguori@us.ibm.com, ehabkost@redhat.com, sw@weilnetz.de,
>> mtosatti@redhat.com, agraf@suse.de, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, jcmvbkbc@gmail.com,
>> avi@redhat.com, "jan kiszka" <jan.kiszka@siemens.com>, afaerber@suse.de, rth@twiddle.net
>> Sent: Monday, June 25, 2012 3:55:03 PM
>> Subject: [Qemu-devel] [PATCH 0/4 v2] target-i386: move tcg intialization	inside CPU object
>>
>> v2:
>>   - drop usage of prev_debug_excp_handler consistently in all users
>>   - split from reset patches to avoid confusion of inter-dependency
>>
>> Compile & Run tested:
>>   target-i386: tcg and kvm mode
>>   i386-linux-user: running of /bin/ls
>> Compile tested:
>>   xtensa-softmmu && xtensaeb-softmmu
>>
>> git tree for testing:
>>   https://github.com/imammedo/qemu/tree/x86cpu_qom_tcg_v2
>>
>>
>> Igor Mammedov (4):
>>   target-i386: drop usage of prev_debug_excp_handler
>>   target-xtensa: drop usage of prev_debug_excp_handler
>>   cleanup cpu_set_debug_excp_handler
>>   target-i386: move tcg initialization into x86_cpu_initfn()
>>
>>  cpu-exec.c             |    5 +----
>>  exec-all.h             |    2 +-
>>  target-i386/cpu.c      |   10 ++++++++++
>>  target-i386/cpu.h      |    1 +
>>  target-i386/helper.c   |   16 +---------------
>>  target-xtensa/helper.c |    8 +-------
>>  6 files changed, 15 insertions(+), 27 deletions(-)
>>
>> --
>> 1.7.10.2
>>
>>
>>
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH 0/4 v2] target-i386: move tcg intialization inside CPU object

[Blue Swirl]

Thanks, applied all.


On Mon, Jul 23, 2012 at 7:46 AM, Igor Mammedov <imammedo@redhat.com> wrote:
> ping.
>
> On 06/25/2012 03:55 PM, Igor Mammedov wrote:
>>
>> v2:
>>    - drop usage of prev_debug_excp_handler consistently in all users
>>    - split from reset patches to avoid confusion of inter-dependency
>>
>> Compile & Run tested:
>>    target-i386: tcg and kvm mode
>>    i386-linux-user: running of /bin/ls
>> Compile tested:
>>    xtensa-softmmu && xtensaeb-softmmu
>>
>> git tree for testing:
>>    https://github.com/imammedo/qemu/tree/x86cpu_qom_tcg_v2
>>
>>
>> Igor Mammedov (4):
>>    target-i386: drop usage of prev_debug_excp_handler
>>    target-xtensa: drop usage of prev_debug_excp_handler
>>    cleanup cpu_set_debug_excp_handler
>>    target-i386: move tcg initialization into x86_cpu_initfn()
>>
>>   cpu-exec.c             |    5 +----
>>   exec-all.h             |    2 +-
>>   target-i386/cpu.c      |   10 ++++++++++
>>   target-i386/cpu.h      |    1 +
>>   target-i386/helper.c   |   16 +---------------
>>   target-xtensa/helper.c |    8 +-------
>>   6 files changed, 15 insertions(+), 27 deletions(-)
>>
>
> --
> -----
>  Igor
>
>
>