From: Frediano Ziglio <fziglio@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: spice-devel@lists.freedesktop.org,
"Lukáš Hrázký" <lhrazky@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest
Date: Fri, 12 Oct 2018 06:46:37 -0400 (EDT) [thread overview]
Message-ID: <1782383806.33244849.1539341197428.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20181012104222.vzwu73lanjbelnbl@sirius.home.kraxel.org>
>
> Hi,
>
> > > When using qemu_console_get_head() it doesn't work correctly, it would
> > > use the qxl card's data. It would work if spice-server would filter the
> > > list to only include the entries for the given display channel before
> > > calling the ->client_monitors_config() callback. But it doesn't, we get
> > > the complete set.
> >
> > That's why I said is a bug, IMHO it should.
>
> Hmm, this should be easily detectable on qemu side I think. If
> num_of_monitors (for a non-qxl card) is > 1, then we have an old,
> non-filtering spice-server. If num_of_monitors == 1, then it is a new,
> filtering spice-server. Or a single-head channel configuration, in
> which case it doesn't matter whenever it filters or not.
>
> So this should be fixable without causing too much compatibility pain.
>
> cheers,
> Gerd
>
Sorry, why fixing in Qemu is the bug is in spice-server?
I really don't follow your reasoning.
For me Qemu should not change at all and spice-server should
do the filtering. Is this not fixing everything?
Frediano
next prev parent reply other threads:[~2018-10-12 10:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 13:10 [Qemu-devel] [RFC PATCH spice/qemu 0/2] QXL interface to set monitor ID Lukáš Hrázký
2018-10-09 13:10 ` [Qemu-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest Lukáš Hrázký
2018-10-09 19:33 ` [Qemu-devel] [Spice-devel] " Jonathon Jongsma
2018-10-10 10:37 ` Gerd Hoffmann
2018-10-11 12:55 ` Lukáš Hrázký
2018-10-11 13:20 ` Gerd Hoffmann
2018-10-11 13:31 ` Lukáš Hrázký
2018-10-11 13:45 ` Gerd Hoffmann
2018-10-10 16:36 ` Lukáš Hrázký
2018-10-11 12:27 ` Gerd Hoffmann
2018-10-11 13:07 ` Frediano Ziglio
2018-10-11 13:12 ` Lukáš Hrázký
2018-10-11 13:43 ` Gerd Hoffmann
2018-10-11 14:30 ` Lukáš Hrázký
2018-10-11 15:09 ` Gerd Hoffmann
2018-10-11 15:37 ` Lukáš Hrázký
2018-10-12 9:27 ` Gerd Hoffmann
2018-10-12 9:54 ` Lukáš Hrázký
2018-10-12 10:15 ` Frediano Ziglio
2018-10-12 10:42 ` Gerd Hoffmann
2018-10-12 10:46 ` Frediano Ziglio [this message]
2018-10-12 11:05 ` Gerd Hoffmann
2018-10-09 13:10 ` [Qemu-devel] [RFC PATCH qemu 2/2] spice: set PCI path and device display ID in QXL interface Lukáš Hrázký
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1782383806.33244849.1539341197428.JavaMail.zimbra@redhat.com \
--to=fziglio@redhat.com \
--cc=kraxel@redhat.com \
--cc=lhrazky@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).