From: Eric Blake <eblake@redhat.com>
To: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>, qemu-devel@nongnu.org
Cc: kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] archive-source.sh: Modern shell scripting (use $() instead of ``)
Date: Mon, 15 Oct 2018 10:44:50 -0500 [thread overview]
Message-ID: <17897835-a1b1-12bd-a0ef-f39d900b59ce@redhat.com> (raw)
In-Reply-To: <20181015065157.3634-1-maozhongyi@cmss.chinamobile.com>
On 10/15/18 1:51 AM, Mao Zhongyi wrote:
> Various shell files contain a mix between obsolete `` and
> modern $(); use of `` is only required when using /bin/sh
> on Solaris. It would be nice to convert to using $()
> everywhere, or at least in all bash scripts, as well as in
> all scripts that are known to not be run on Solaris.
Did you have a particular program you used to find these, or just grep?
Also, when sending a series, don't forget a 0/3 cover letter.
>
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
> ---
> scripts/archive-source.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-10-16 15:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 6:51 [Qemu-devel] [PATCH 1/3] archive-source.sh: Modern shell scripting (use $() instead of ``) Mao Zhongyi
2018-10-15 6:51 ` [Qemu-devel] [PATCH 2/3] git-submodule.sh: " Mao Zhongyi
2018-10-15 7:09 ` Thomas Huth
2018-10-15 6:51 ` [Qemu-devel] [PATCH 3/3] show-fixed-bugs.sh: " Mao Zhongyi
2018-10-15 7:12 ` Thomas Huth
2018-10-15 7:07 ` [Qemu-devel] [PATCH 1/3] archive-source.sh: " Thomas Huth
2018-10-15 7:31 ` [Qemu-devel] [PATCH 1/3] archive-source.sh: Modern shellscripting " maozy
2018-10-15 8:05 ` [Qemu-devel] [PATCH 1/3] archive-source.sh: Modern shell scripting " Markus Armbruster
2018-10-15 15:44 ` Eric Blake [this message]
2018-10-17 1:52 ` [Qemu-devel] [PATCH 1/3] archive-source.sh: Modern shellscripting " maozy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17897835-a1b1-12bd-a0ef-f39d900b59ce@redhat.com \
--to=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=maozhongyi@cmss.chinamobile.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).