From: David Hildenbrand <david@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org,
Matthew Rosato <mjrosato@linux.vnet.ibm.com>,
thuth@redhat.com, Eduardo Habkost <ehabkost@redhat.com>,
cohuck@redhat.com,
Richard Henderson <richard.henderson@linaro.org>,
Alexander Graf <agraf@suse.de>,
Markus Armbruster <armbru@redhat.com>,
borntraeger@de.ibm.com, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 00/21] s390x cleanups and CPU hotplug via device_add
Date: Tue, 12 Sep 2017 15:56:17 +0200 [thread overview]
Message-ID: <17978d23-82c1-3bf4-23ee-315867fc038d@redhat.com> (raw)
In-Reply-To: <20170912155502.5ee2d753@nial.brq.redhat.com>
On 12.09.2017 15:55, Igor Mammedov wrote:
> On Mon, 11 Sep 2017 17:21:29 +0200
> David Hildenbrand <david@redhat.com> wrote:
>
>> The first patches are a bunch of cleanups. I decided to go the
>> extra mile and implement CPU hotplug via "device_add", as well as
>> "query-hotpluggable-cpus".
>>
>> On s390x, only complete cores can be plugged. CPU hot unplug is currently
>> not supported by the architecture.
>>
>> Support for hotplugging CPUs in random core-id order (last two patches)
>> is added. We once hat a KVM bug preventing this, but the stable patch
>> should now be included in relevant places - 152e9f65d66f ("KVM: s390: fix
>> wrong lookup of VCPUs by array index"). Current tooling will plug them in
>> sequential order anyway, so it should not hurt.
>
> do you plan to convert hw/s390x/s390-virtio.c machine to possible_cpus as well?
> it's not necessary to enable hotplug on it but sharing code and initializing
> cpus the same way would be plus.
See patch #3. s390-virtio.c is an old leftover, the machine doesn't
exist anymore. So this should be clean.
--
Thanks,
David
prev parent reply other threads:[~2017-09-12 13:56 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 15:21 [Qemu-devel] [PATCH v4 00/21] s390x cleanups and CPU hotplug via device_add David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 01/21] exec, dump, i386, ppc, s390x: don't include exec/cpu-all.h explicitly David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 02/21] cpu: drop old comments describing members David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 03/21] s390x: get rid of s390-virtio.c David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 04/21] s390x: rename s390-virtio.h to s390-virtio-hcall.h David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 05/21] s390x: move s390_virtio_hypercall() " David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 06/21] s390x: move subsystem_reset() to s390-virtio-ccw.h David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 07/21] target/s390x: move some s390x typedefs to cpu-qom.h David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 08/21] s390x: move sclp_service_call() to sclp.h David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 09/21] target/s390x: use trigger_pgm_exception() in s390_cpu_handle_mmu_fault() David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 10/21] target/s390x: use program_interrupt() in per_check_exception() David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 11/21] s390x: allow only 1 CPU with TCG David Hildenbrand
2017-09-12 12:43 ` Igor Mammedov
2017-09-12 15:42 ` David Hildenbrand
2017-09-13 7:19 ` Igor Mammedov
2017-09-13 12:10 ` David Hildenbrand
2017-09-13 12:35 ` Cornelia Huck
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 12/21] target/s390x: set cpu->id for linux user when realizing David Hildenbrand
2017-09-12 12:46 ` Igor Mammedov
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 13/21] target/s390x: use "core-id" for cpu number/address/id handling David Hildenbrand
2017-09-12 13:07 ` Igor Mammedov
2017-09-12 13:15 ` David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 14/21] target/s390x: rename next_cpu_id to next_core_id David Hildenbrand
2017-09-12 13:09 ` Igor Mammedov
2017-09-12 13:16 ` David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 15/21] s390x: print CPU definitions in sorted order David Hildenbrand
2017-09-12 10:51 ` Christian Borntraeger
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 16/21] s390x: allow cpu hotplug via device_add David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 17/21] s390x: CPU hot unplug via device_del cannot work for now David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 18/21] s390x: implement query-hotpluggable-cpus David Hildenbrand
2017-09-12 13:43 ` Igor Mammedov
2017-09-12 14:03 ` David Hildenbrand
2017-09-12 14:24 ` Thomas Huth
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 19/21] s390x: get rid of cpu_s390x_create() David Hildenbrand
2017-09-12 13:50 ` Igor Mammedov
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 20/21] s390x: generate sclp cpu information from possible_cpus David Hildenbrand
2017-09-11 15:21 ` [Qemu-devel] [PATCH v4 21/21] s390x: allow CPU hotplug in random core-id order David Hildenbrand
2017-09-12 13:55 ` [Qemu-devel] [PATCH v4 00/21] s390x cleanups and CPU hotplug via device_add Igor Mammedov
2017-09-12 13:56 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17978d23-82c1-3bf4-23ee-315867fc038d@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mjrosato@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).