From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIVKv-0000Un-W9 for qemu-devel@nongnu.org; Wed, 07 Jun 2017 03:25:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIVKs-0005Zd-QE for qemu-devel@nongnu.org; Wed, 07 Jun 2017 03:25:01 -0400 Date: Wed, 7 Jun 2017 03:24:56 -0400 (EDT) From: Paolo Bonzini Message-ID: <1799129848.6598516.1496820296394.JavaMail.zimbra@redhat.com> In-Reply-To: <20170607070732.23312-1-david@gibson.dropbear.id.au> References: <20170607070732.23312-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pseries: Correct panic behaviour for pseries machine type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: mdroth@linux.vnet.ibm.com, thuth@redhat.com, lvivier@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org ----- Original Message ----- > From: "David Gibson" > To: mdroth@linux.vnet.ibm.com, thuth@redhat.com, lvivier@redhat.com > Cc: pbonzini@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, "David Gibson" > Sent: Wednesday, June 7, 2017 9:07:32 AM > Subject: [PATCH] pseries: Correct panic behaviour for pseries machine type > > The pseries machine type doesn't usually use the 'pvpanic' device as such, > because it has a firmware/hypervisor facility with roughly the same > purpose. The 'ibm,os-term' RTAS call notifies the hypervisor that the > guest has crashed. > > Our implementation of this call was sending a GUEST_PANICKED qmp event; > however, it was not doing the other usual panic actions, making its > behaviour different from pvpanic for no good reason. > > To correct this, we should call qemu_system_guest_panicked() rather than > directly sending the panic event. > > Signed-off-by: David Gibson > --- > hw/ppc/spapr_rtas.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c > index 707c4d4..94a2799 100644 > --- a/hw/ppc/spapr_rtas.c > +++ b/hw/ppc/spapr_rtas.c > @@ -293,12 +293,9 @@ static void rtas_ibm_os_term(PowerPCCPU *cpu, > target_ulong args, > uint32_t nret, target_ulong rets) > { > - target_ulong ret = 0; > + qemu_system_guest_panicked(NULL); > > - qapi_event_send_guest_panicked(GUEST_PANIC_ACTION_PAUSE, false, NULL, > - &error_abort); > - > - rtas_st(rets, 0, ret); > + rtas_st(rets, 0, RTAS_OUT_SUCCESS); > } It's possible to "cont" a panicked guest, so I think you should keep the rtas_st. Paolo