From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: Eduardo Habkost <eduardo@habkost.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Richard Henderson <richard.henderson@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH v2 01/16] hw/i386/pc_q35: Resolve redundant q35_host variable
Date: Thu, 29 Jun 2023 09:43:14 +0200 [thread overview]
Message-ID: <17acd75b-72cb-a4d7-9d06-c78693423b6b@linaro.org> (raw)
In-Reply-To: <20230628195204.1241-2-shentey@gmail.com>
On 28/6/23 21:51, Bernhard Beschow wrote:
> The variable is redundant to "phb" and is never used by its real type.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/i386/pc_q35.c | 27 +++++++++++++--------------
> 1 file changed, 13 insertions(+), 14 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-06-29 7:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 19:51 [PATCH v2 00/16] Q35 and I440FX host bridge QOM cleanup Bernhard Beschow
2023-06-28 19:51 ` [PATCH v2 01/16] hw/i386/pc_q35: Resolve redundant q35_host variable Bernhard Beschow
2023-06-29 7:43 ` Philippe Mathieu-Daudé [this message]
2023-06-28 19:51 ` [PATCH v2 02/16] hw/pci-host/q35: Fix double, contradicting .endianness assignment Bernhard Beschow
2023-06-29 7:42 ` Philippe Mathieu-Daudé
2023-06-28 19:51 ` [PATCH v2 03/16] hw/pci-host/q35: Initialize PCMachineState::bus in board code Bernhard Beschow
2023-06-28 19:51 ` [PATCH v2 04/16] hw/pci/pci_host: Introduce PCI_HOST_BYPASS_IOMMU macro Bernhard Beschow
2023-06-28 19:51 ` [PATCH v2 05/16] hw/pci-host/q35: Initialize PCI_HOST_BYPASS_IOMMU property from board code Bernhard Beschow
2023-06-28 19:51 ` [PATCH v2 06/16] hw/pci-host/q35: Make some property name macros reusable by i440fx Bernhard Beschow
2023-06-28 19:51 ` [PATCH v2 07/16] hw/pci-host/i440fx: Replace magic values by existing constants Bernhard Beschow
2023-06-28 19:51 ` [PATCH v2 08/16] hw/pci-host/i440fx: Have common names for some local variables Bernhard Beschow
2023-06-28 19:51 ` [PATCH v2 09/16] hw/pci-host/i440fx: Move i440fx_realize() into PCII440FXState section Bernhard Beschow
2023-06-28 19:51 ` [PATCH v2 10/16] hw/pci-host/i440fx: Make MemoryRegion pointers accessible as properties Bernhard Beschow
2023-06-28 19:51 ` [PATCH v2 11/16] hw/pci-host/i440fx: Add PCI_HOST_PROP_IO_MEM property Bernhard Beschow
2023-06-28 19:52 ` [PATCH v2 12/16] hw/pci-host/i440fx: Add PCI_HOST_{ABOVE, BELOW}_4G_MEM_SIZE properties Bernhard Beschow
2023-06-28 19:52 ` [PATCH v2 13/16] hw/pci-host/i440fx: Add I440FX_HOST_PROP_PCI_TYPE property Bernhard Beschow
2023-06-28 19:52 ` [PATCH v2 14/16] hw/pci-host/i440fx: Resolve i440fx_init() Bernhard Beschow
2023-06-29 7:50 ` Philippe Mathieu-Daudé
2023-06-29 16:52 ` Bernhard Beschow
2023-06-28 19:52 ` [PATCH v2 15/16] hw/i386/pc_piix: Turn some local variables into initializers Bernhard Beschow
2023-06-29 7:39 ` Philippe Mathieu-Daudé
2023-06-28 19:52 ` [PATCH v2 16/16] hw/i386/pc_piix: Move i440fx' realize near its qdev_new() Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17acd75b-72cb-a4d7-9d06-c78693423b6b@linaro.org \
--to=philmd@linaro.org \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).