From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92D14C87FD2 for ; Mon, 11 Aug 2025 11:46:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ulQyr-0002wb-Sn; Mon, 11 Aug 2025 07:46:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulQy4-0002hb-2X for qemu-devel@nongnu.org; Mon, 11 Aug 2025 07:45:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulQxx-0008Ry-Bk for qemu-devel@nongnu.org; Mon, 11 Aug 2025 07:45:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754912722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ChNCxeaVDlVyG/bUN9/eGHBvIjLnngv9NIsTw9iVxlI=; b=WwNozxO4TSCtyIivCRPDJR7glene97+uVw34AIEde5JVxeEgWtt0M8ZKhezRvRdYjIAuV+ aIzSdIIWrWEeQw/mUzzNJ1EvB+WV+RJKI3DEU4J8+tTQ7qiGiMvvOZ+Z/tEkeiHT6JQyzR kldcC1EZIwksH6ipeonXkab9y9m6QVk= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-diu1X7CyMmqaDI5pLVQ4Sg-1; Mon, 11 Aug 2025 07:45:20 -0400 X-MC-Unique: diu1X7CyMmqaDI5pLVQ4Sg-1 X-Mimecast-MFC-AGG-ID: diu1X7CyMmqaDI5pLVQ4Sg_1754912719 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7e7ffcbce3bso1356600885a.0 for ; Mon, 11 Aug 2025 04:45:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754912719; x=1755517519; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ChNCxeaVDlVyG/bUN9/eGHBvIjLnngv9NIsTw9iVxlI=; b=EyJDR/3fRmXr3ZfgYiye7VK34Iy12QC7RZuSvRW1PjmlzB07/FXskbRMdw4lpYJ6Zj rCvg8jHm7Ko/KwLkTCsX/bwmoDMdqvp2RlakSWxigBnJLjXQlsufE8N7W9NaladXfEBC CjXqz48LZZCIdbFcqXqEE5YduccZm7kbfOZ73m14oWnf8+oA60u4BTDMZV05hCD/25yU KAzVnzZMVCuRYF3bIqOnammF/71tgCJ5gDg2KyOFMFwXVX1XeX7aPGiqfbZmNk+kfaY8 yvqK0LHe1R78x9FTr+Aq30rtChF9/JVduHCnBSppg9fFEyfA2A2gMWqt6wZEaLCs2O10 In0Q== X-Forwarded-Encrypted: i=1; AJvYcCVTWRQxT8gl3Y8aImIb9mHsXRmKxSNF0MSsKf36iUjZJ6mO0lQ0QfzCwUxLed12ub60ozNV7jZKSIA6@nongnu.org X-Gm-Message-State: AOJu0YzS/wX7KpHxkoHU5vaa/P9lUT9KXLUHuk4wW0UjQjbu9GZZe0sK tiksypjL865yOxkVv1juxNBq90nzI+ow5B6QHcKqrK/SStWK3+Jm1W6h6EAPZhjHHyQJPQoYDOf qlWYhyIixbDxShMgLin/AMq0A1arMhSPM7jv1QxJrD6FcrNaK3d2su6/r X-Gm-Gg: ASbGncuzLfgKk3TWTl22nNc3NQ1MO9NnBklD69VNpKbx5/1+DTXZPq4dsCPyn7XPuj6 rdqFuogRQlhWOECHKIFR424GbfJA/8VygCs080ktMdrZaAxXQocobF18Amhl4ETVgDKR5lObGn1 EDbpjdW6jHbkcEPxiOzXmHVlRi0FELQyskaJpJ/5vef2g2Debygjo/5w26ogRio1zVTg0boBjez 7LXTHrWKrO5jHCp7gXhdH1aIa0nJZo8LPocdQx6M4KTy1u3LoJ0vNypONMC1tvOsUWQ0e7hKHy2 9kOdNdgLmGvvGO7/RJfqF8SaeM+5CGO72IpMrOdDd/wd7tMmcxD5pAoDOXVjwbA9creW83hTkzx yQQ== X-Received: by 2002:a05:620a:2908:b0:7e6:998c:99c0 with SMTP id af79cd13be357-7e82c6ab77fmr1668934485a.24.1754912719537; Mon, 11 Aug 2025 04:45:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEwob62lbxiI9/ZrQEkdAvp1gpbk6ivhW20d2bcZlhGrT1VeG912bnrckofDsIbIQ6XSwQItQ== X-Received: by 2002:a05:620a:2908:b0:7e6:998c:99c0 with SMTP id af79cd13be357-7e82c6ab77fmr1668926485a.24.1754912718933; Mon, 11 Aug 2025 04:45:18 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:576b:abc6:6396:ed4a? ([2a01:e0a:280:24f0:576b:abc6:6396:ed4a]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e695e69ed5sm1325402585a.46.2025.08.11.04.45.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Aug 2025 04:45:18 -0700 (PDT) Message-ID: <17b110f7-e62a-4210-9acf-54cefe7be1d5@redhat.com> Date: Mon, 11 Aug 2025 13:45:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/22] vfio/vfio-container.h: update VFIOContainer declaration To: Mark Cave-Ayland , npiggin@gmail.com, danielhb413@gmail.com, harshpb@linux.ibm.com, mjrosato@linux.ibm.com, farman@linux.ibm.com, pasic@linux.ibm.com, borntraeger@linux.ibm.com, thuth@redhat.com, richard.henderson@linaro.org, david@redhat.com, iii@linux.ibm.com, john.levon@nutanix.com, thanos.makatos@nutanix.com, alex.williamson@redhat.com, steven.sistare@oracle.com, tomitamoeko@gmail.com, qemu-ppc@nongnu.org, qemu-s390x@nongnu.org, qemu-devel@nongnu.org References: <20250715093110.107317-1-mark.caveayland@nutanix.com> <20250715093110.107317-3-mark.caveayland@nutanix.com> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Language: en-US, fr Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <20250715093110.107317-3-mark.caveayland@nutanix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/15/25 11:25, Mark Cave-Ayland wrote: > Update the VFIOContainer declaration so that it is closer to our coding > guidelines: emove the explicit typedef (this is already handled by the > OBJECT_DECLARE_TYPE() macro) and add a blank line after the parent object. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Cédric Le Goater Thanks, C. > --- > include/hw/vfio/vfio-container.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/hw/vfio/vfio-container.h b/include/hw/vfio/vfio-container.h > index 21e5807e48..50c91788d5 100644 > --- a/include/hw/vfio/vfio-container.h > +++ b/include/hw/vfio/vfio-container.h > @@ -25,13 +25,14 @@ typedef struct VFIOGroup { > bool ram_block_discard_allowed; > } VFIOGroup; > > -typedef struct VFIOContainer { > +struct VFIOContainer { > VFIOContainerBase bcontainer; > + > int fd; /* /dev/vfio/vfio, empowered by the attached groups */ > unsigned iommu_type; > QLIST_HEAD(, VFIOGroup) group_list; > VFIOContainerCPR cpr; > -} VFIOContainer; > +}; > > OBJECT_DECLARE_SIMPLE_TYPE(VFIOContainer, VFIO_IOMMU_LEGACY); >