Re: [RFC PATCH v2 20/48] cpus: Rename 'vcpu_dirty' field as negated 'hwaccel_synchronized'

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 22/6/25 03:35, Richard Henderson wrote:
> On 6/20/25 10:13, Philippe Mathieu-Daudé wrote:
>> Try to better describe which side is dirty (QEMU process or
>> hardware accelerator) by renaming as @hwaccel_synchronized.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>>   include/hw/core/cpu.h |  4 ++--
>>   accel/kvm/kvm-all.c   | 20 ++++++++++----------
>>   target/mips/kvm.c     |  4 ++--
>>   3 files changed, 14 insertions(+), 14 deletions(-)
>>
>> diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
>> index 69ea425c458..d5f82609943 100644
>> --- a/include/hw/core/cpu.h
>> +++ b/include/hw/core/cpu.h
>> @@ -441,7 +441,7 @@ struct qemu_work_item;
>>    * @opaque: User data.
>>    * @mem_io_pc: Host Program Counter at which the memory was accessed.
>>    * @accel: Pointer to accelerator specific state.
>> - * @vcpu_dirty: Hardware accelerator is not synchronized with QEMU state
>> + * @hwaccel_synchronized: Hardware accelerator is synchronized with 
>> QEMU state
> 
> Is this change really helpful?  It isn't to me...
> 
> If you want to change anything, this could be a tri-state enum:
> 
>    - qemu state is current
>    - hwaccel state is current
>    - qemu+hwaccel are synced

Good idea. I'll drop these patches for now.