From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AA81C87FD3 for ; Thu, 31 Jul 2025 23:30:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uhci4-0000LQ-Bu; Thu, 31 Jul 2025 19:29:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uhchz-0000HO-Ut for qemu-devel@nongnu.org; Thu, 31 Jul 2025 19:29:14 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uhchw-00011P-T0 for qemu-devel@nongnu.org; Thu, 31 Jul 2025 19:29:11 -0400 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-76bc5e68d96so1092607b3a.3 for ; Thu, 31 Jul 2025 16:29:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754004547; x=1754609347; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sdjEZ9slcM++BFYLU7laFQNr4veY1GlPSOXXS/wGY0E=; b=rTn6QggycWFDOCe6SXfypPg3PQBEAPbenJgU9AGoatFvrOovqvEFuO6Ln7IXP1Cohm 9ilMlIDb92FDbzSYTuSa+TrFCyiRyYsM7RVvYUosE6hIQgFPNc8CTzfnq/TvZe7DkQ/R q9L+hV9eanuDOeJ+D6r8jmb0IGbARI76x8JNKTjfuO34rJAdpdX205JWH9h2Q9sQ9CVc A5nIVrRCH92PM6k2jUu8FSpnPj4iXBqAhFC0o9WY1jC8y7myrxQzU6Y9zQg3450bu5a4 7g/kFLOIdENLE3ou06zqQHslUuK+6hrt9ZvZlQC6LAU/bKq99IGXaAqKavf2QuWsC2jW qa7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754004547; x=1754609347; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sdjEZ9slcM++BFYLU7laFQNr4veY1GlPSOXXS/wGY0E=; b=nf1oZv8CEHUPAJHiIMXrtA12L2FouznaE/0tOQScxxu8JU+fsfW4RpMbYToX6wcYxJ C2/zFOvIgzI5tA64BShflrJoOYqc3Vbvqnx3Vj0UXl0yxKzqhV11YVb3XKMTQ3/yBkDd ht0xVtA2wCkFggHlIa/hZdXahwUkewJDWoutf5MmWr81AaXgzB8/QBpolyP8Yk4HXS9j SBkvZX1YfTm72P3x3o4qrxa50Nx/m6UGx6Du7xwUDeBVPuEyswHOSbgws7tdH2GUQbfH YprTRokZIpMae2midAf/7HcDi5f7I8lZEesfDJn96ClYtXam1mCO3dNjEBWHOpEWweAz v28Q== X-Forwarded-Encrypted: i=1; AJvYcCW4GIIV3W+Zaz7Lf3afmYBJ4qD+RyTlLQIOK3csTmCr5G+Y79IOp3AVxZyO0pw6lgT7/mlQ+xq0Fv4a@nongnu.org X-Gm-Message-State: AOJu0YzhIJWbUiDbeKlHzeesdyCPrBpaoKsl1C7yeKJzzo7wMBWfNYJA n4wCjlp40fcNiDvXPdRkmYGs87v/T74XFfD4vKyN1FvHBcOJJ+mvQOGGw26OSS5nS+Q= X-Gm-Gg: ASbGncsZYqNV6RUgNA1VTsOx7J45HiB0q2t65BJZm1u3rN1UAAzyhOaSvdANLnLJTV5 8cvyX59IYhlVwo36EhjTrq20OOPmXlfScfijM5pZftafPNprChzeTA9q1IGOpt7kju2FJWlqa1K AvhUXgHWWpJzzU0+IqGqZ5cG4img0dESA1l+ouYD0TgK86yfjEws9V/euXUN5znPS+Ed6C1Rrzh tCxv7Y+aBkSL4k92HdiGuvzSbwbkziU6pRHQNxQsIWOdnXmPzII0WhgAqilaGA66RMPCbAkjSOZ M6sa7rqzTLmsy9WJ5CzkMpDE9Tl9hQGAf9zrhK0iTizo3D4mqWS0v666sp+1lXMNAKOJVo+DAtE fxJNH2/qqApFf93zFD7OpGqfnzC8kWtKy1Hs3/HPO X-Google-Smtp-Source: AGHT+IEEZzSacknaXTABZ2KItV7zNzAyBJqlSB4WNUVdwwOQyM7U+gp13B3JO9jS3722wCGDy8+erw== X-Received: by 2002:a05:6a00:2e0e:b0:749:4fd7:3513 with SMTP id d2e1a72fcca58-76ab3096e9dmr11415310b3a.16.1754004547347; Thu, 31 Jul 2025 16:29:07 -0700 (PDT) Received: from [192.168.4.112] ([180.233.125.160]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76bcce6f30bsm2597471b3a.16.2025.07.31.16.29.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Jul 2025 16:29:06 -0700 (PDT) Message-ID: <17ca7cee-4aec-41ca-a653-ccf6383f3c04@linaro.org> Date: Fri, 1 Aug 2025 09:28:58 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/10] semihosting/arm-compat-semi: eradicate sizeof(target_ulong) To: Pierrick Bouvier , qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?Q?Alex_Benn=C3=A9e?= , Weiwei Li , philmd@linaro.org, Liu Zhiwei , Palmer Dabbelt , qemu-riscv@nongnu.org, Alistair Francis References: <20250730220621.1142496-1-pierrick.bouvier@linaro.org> <20250730220621.1142496-7-pierrick.bouvier@linaro.org> From: Richard Henderson Content-Language: en-US In-Reply-To: <20250730220621.1142496-7-pierrick.bouvier@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x432.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/31/25 08:06, Pierrick Bouvier wrote: > No semantic change. > > Signed-off-by: Pierrick Bouvier > --- > semihosting/arm-compat-semi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c > index 5a04ce55ca9..e5a665d604b 100644 > --- a/semihosting/arm-compat-semi.c > +++ b/semihosting/arm-compat-semi.c > @@ -787,7 +787,7 @@ void do_common_semihosting(CPUState *cs) > > case TARGET_SYS_ELAPSED: > elapsed = get_clock() - clock_start; > - if (sizeof(target_ulong) == 8) { > + if (is_64bit_semihosting(env)) { > if (SET_ARG(0, elapsed)) { > goto do_fault; > } Reviewed-by: Richard Henderson r~