Re: [PATCH v2 4/5] MAINTAINERS: Adjust maintainership for R4000 systems

["Hervé Poussineau" <hpoussin@reactos.org>]

Le 22/11/2019 à 16:29, Philippe Mathieu-Daudé a écrit :
> On 11/22/19 3:14 PM, Aleksandar Markovic wrote:
>> On Fri, Nov 22, 2019 at 2:58 PM Philippe Mathieu-Daudé
>> <philmd@redhat.com> wrote:
>>>
>>> Hi Aleksandar,
>>>
>>> On 11/13/19 2:47 PM, Aleksandar Markovic wrote:
>>>> From: Aleksandar Markovic <amarkovic@wavecomp.com>
>>>>
>>>> Change the maintainership for R4000 systems to improve its quality.
>>>>
>>>> Acked-by: Aurelien Jarno <aurelien@aurel32.net>
>>>> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
>>>> ---
>>>>    MAINTAINERS | 5 +++--
>>>>    1 file changed, 3 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index 6afec32..ba9ca98 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -971,8 +971,9 @@ F: hw/mips/mips_mipssim.c
>>>>    F: hw/net/mipsnet.c
>>>>
>>>>    R4000
>>>> -M: Aurelien Jarno <aurelien@aurel32.net>
>>>> -R: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>
>>>> +M: Hervé Poussineau <hpoussin@reactos.org>
>>>
>>> Commit 0c10962a033 from Hervé was part of a bigger refactor series, so I
>>> don't think he is interested.
>>>
>>>> +R: Aurelien Jarno <aurelien@aurel32.net>
>>>> +R: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>>    S: Maintained
>>>>    F: hw/mips/mips_r4k.c
>>>
>>> Now back to this board, I am having hard time to understand what it
>>> models. IIUC it predates the Malta board, and was trying to model a
>>> board able to run the first MIPS cpu when the port was added in 2005
>>> (see commit 6af0bf9c7c3a).
>>> The Malta board was added 1 year later (commit 5856de800df) and models a
>>> real hardware.
>>>
>>> As Aurelien acked to step down maintaining it, it seems the perfect
>>> timing to start its deprecation process. I'll prepare a patch for 5.0
>>> (unless someone is really using it and willing to maintain it).
>>>
>>
>> Philippe, hi.
>>
>> Herve told me a while ago that he does care about R4000 being
>> supported, as it is closely related to Jazz machines, so please
>> don't start any deprecation process.
> 
> I think what Hervé meant to say is he cares about the R4000 CPU (implementing the MIPSIII architecture). The Magnum and Pica boards indeed use a R4000 CPU. I also personally care about this CPU, and 
> don't want it to disappear.
> 
> Here we are talking about the some Frankenstein board. QEMU aims to model real hardware, with the exception of the 'Virt' boards that have specifications. Here I can't find any. I am not against Hervé 
> maintaining this file if he has some interest in it, but I think there are confusion and we are talking about 2 different topics.

Philippe is right.
I care about Magnum/PICA boards (which have a R4000 cpu).
I don't care about this the mips_r4k.c machine, and I think that deprecating mips_r4k.c machine is the right thing to do.

> 
>> Herve is the most familiar of all of us with R4000, and, for that
>> reason, my suggestion is to keep the patch as it is. Let me know
>> if you have any objections.
>>
>> One alternative approach would be to merge "R4000" and
>> "Jazz" sections. But, let's leave it for future as an option,
>> if nobody objects.

Jazz and mips_r4k machines have mostly nothing in common, except using a R4000 CPU and an ISA bus.

Regards,

Hervé