qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Yang Zhong <yang.zhong@intel.com>, qemu-devel@nongnu.org
Cc: seanjc@google.com, eblake@redhat.com
Subject: Re: [PATCH 6/7] monitor: Fix coredump issue in non-x86 platform
Date: Wed, 8 Sep 2021 10:54:06 +0200	[thread overview]
Message-ID: <17d61d04-4276-dd5b-b23f-9597c1fad1f1@redhat.com> (raw)
In-Reply-To: <20210908081937.77254-7-yang.zhong@intel.com>

On 08/09/21 10:19, Yang Zhong wrote:
> +    if (sgx_enabled) {
> +        MachineState *ms = MACHINE(qdev_get_machine());
> +        X86MachineState *x86ms = X86_MACHINE(qdev_get_machine());
> +

You can use object_dynamic_cast(ms, TYPE_PC_MACHINE), something like:


PCMachineState *pcms =
     object_dynamic_cast(qdev_get_machine(), TYPE_PC_MACHINE);
X86MachineState *x86ms;

if (!pcms) {
     return NULL;
}
x86ms = X86_MACHINE(pcms);
if (!x86ms->sgx_epc_list) {
     return NULL;
}
info = g_new0(SGXInfo, 1);
...
return info;

Also please squash this patch directly into patch 3 that introduces 
sgx_get_info.

Paolo



  parent reply	other threads:[~2021-09-08  8:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08  8:19 [PATCH 0/7] The HMP/QMP interfaces in Qemu SGX Yang Zhong
2021-09-08  8:19 ` [PATCH 1/7] qmp: Add query-sgx command Yang Zhong
2021-09-08  8:19 ` [PATCH 2/7] hmp: Add 'info sgx' command Yang Zhong
2021-09-08  8:19 ` [PATCH 3/7] i386: Add sgx_get_info() interface Yang Zhong
2021-09-08  8:32   ` Philippe Mathieu-Daudé
2021-09-09  2:20     ` Yang Zhong
2021-09-08  8:55   ` Paolo Bonzini
2021-09-09  7:05     ` Yang Zhong
2021-09-08  8:19 ` [PATCH 4/7] bitops: Support 32 and 64 bit mask macro Yang Zhong
2021-09-08  8:34   ` Philippe Mathieu-Daudé
2021-09-09  2:04     ` Yang Zhong
2021-09-08  8:19 ` [PATCH 5/7] qmp: Add the qmp_query_sgx_capabilities() Yang Zhong
2021-09-08  8:38   ` Philippe Mathieu-Daudé
2021-09-09  2:51     ` Yang Zhong
2021-09-09  9:36       ` Philippe Mathieu-Daudé
2021-09-09 12:06         ` Yang Zhong
2021-09-09 13:25           ` Philippe Mathieu-Daudé
2021-09-08  8:19 ` [PATCH 6/7] monitor: Fix coredump issue in non-x86 platform Yang Zhong
2021-09-08  8:53   ` Philippe Mathieu-Daudé
2021-09-08  8:54   ` Paolo Bonzini [this message]
2021-09-09  6:48     ` Yang Zhong
2021-09-08  8:19 ` [PATCH 7/7] pc: Cleanup the SGX definitions Yang Zhong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17d61d04-4276-dd5b-b23f-9597c1fad1f1@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=seanjc@google.com \
    --cc=yang.zhong@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).