From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blNVe-0004Fz-FZ for qemu-devel@nongnu.org; Sat, 17 Sep 2016 17:50:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1blNVd-0004Ql-BB for qemu-devel@nongnu.org; Sat, 17 Sep 2016 17:50:54 -0400 References: <1471418906-27591-1-git-send-email-famz@redhat.com> <1471418906-27591-9-git-send-email-famz@redhat.com> From: Eric Blake Message-ID: <17dd2ccb-d1ff-b4b9-44ea-c4bff932fc5f@redhat.com> Date: Sat, 17 Sep 2016 16:50:43 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NMMEHjWhb4uJnEEVjehIau2uHjTRNbfwx" Subject: Re: [Qemu-devel] [PATCH v6 8/9] vl: Switch qemu_uuid to QemuUUID List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org, sw@weilnetz.de, jcody@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com, pbonzini@redhat.com, mreitz@redhat.com, rth@twiddle.net This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NMMEHjWhb4uJnEEVjehIau2uHjTRNbfwx From: Eric Blake To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org, sw@weilnetz.de, jcody@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com, pbonzini@redhat.com, mreitz@redhat.com, rth@twiddle.net Message-ID: <17dd2ccb-d1ff-b4b9-44ea-c4bff932fc5f@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 8/9] vl: Switch qemu_uuid to QemuUUID References: <1471418906-27591-1-git-send-email-famz@redhat.com> <1471418906-27591-9-git-send-email-famz@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/17/2016 04:38 PM, Eric Blake wrote: > On 08/17/2016 02:28 AM, Fam Zheng wrote: >> Update all qemu_uuid users as well, especially get rid of the duplicat= ed >> low level g_strdup_printf, sscanf and snprintf calls with QEMU UUID AP= I. >> >> Since qemu_uuid_parse is quite tangled with qemu_uuid, it's switching = to >> QemuUUID is done here too to keep everything in sync and avoid code >> churn. >> >> Signed-off-by: Fam Zheng >> --- >=20 > Reviewed-by: Eric Blake >=20 Spoke too soon; this fails compilation for me, because you missed a few spots: CC ui/sdl2-2d.o ui/spice-core.c: In function =E2=80=98qemu_spice_init=E2=80=99: ui/spice-core.c:799:41: error: incompatible type for argument 2 of =E2=80=98spice_server_set_uuid=E2=80=99 spice_server_set_uuid(spice_server, qemu_uuid); ^~~~~~~~~ In file included from /usr/include/spice-server/spice.h:25:0, from ui/spice-core.c:19: /usr/include/spice-server/spice-server.h:121:6: note: expected =E2=80=98c= onst uint8_t * {aka const unsigned char *}=E2=80=99 but argument is of type =E2= =80=98QemuUUID {aka struct }=E2=80=99 void spice_server_set_uuid(SpiceServer *s, const uint8_t uuid[16]); ^~~~~~~~~~~~~~~~~~~~~ /home/eblake/qemu/hw/ppc/spapr_rtas.c: In function =E2=80=98rtas_ibm_get_system_parameter=E2=80=99: /home/eblake/qemu/hw/ppc/spapr_rtas.c:306:42: error: incompatible type for argument 3 of =E2=80=98sysparm_st=E2=80=99 ret =3D sysparm_st(buffer, length, qemu_uuid, (qemu_uuid_set ? 1= 6 : 0)); ^~~~~~~~~ /home/eblake/qemu/hw/ppc/spapr_rtas.c:261:19: note: expected =E2=80=98con= st void *=E2=80=99 but argument is of type =E2=80=98QemuUUID {aka struct }=E2=80=99 static inline int sysparm_st(target_ulong addr, target_ulong len, ^~~~~~~~~~ /home/eblake/qemu/rules.mak:60: recipe for target 'hw/ppc/spapr_rtas.o' failed The fixups should be obvious, though, so fold them in, and you can keep R= -b. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NMMEHjWhb4uJnEEVjehIau2uHjTRNbfwx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX3bqzAAoJEKeha0olJ0NqvFwH/iImlpc1kJHnpcom0uqXeGLO DmKJpxM0NjJQKVa4MmnUw00xySTcgBBf4TW/up4swR1+chU3/pyF6e3EsXrnMMpb Cg/7gSta3fESZAqKKTPVRtZ8IJS/2aa/xLebXh5g3VfjPVX4IkrXpufNIV9HapOV N9ZAfGaWCwh6cSXXC9spNP8nLkJo0YySBOQp5rh+3k3Ht38jgJwHWo0/0aqDV+5s J58JZRyQAvNmjBXRMJ2XabneLG02IZsJh0x1gUBHtr9swvRUIlqdFCn8EF3ip07q beShDngO3a5X2Fsf74bCwFldpEr2/zyKZC2ib8HAuSCBPZMl5rWULpBA05+q3JU= =nfQF -----END PGP SIGNATURE----- --NMMEHjWhb4uJnEEVjehIau2uHjTRNbfwx--