From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:46304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDmIu-00009n-Ky for qemu-devel@nongnu.org; Tue, 09 Apr 2019 04:40:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDmIt-0005ef-Ou for qemu-devel@nongnu.org; Tue, 09 Apr 2019 04:40:28 -0400 References: <9409d9bf-c513-d82b-d438-9173fc582d7f@redhat.com> <87mukzei52.fsf@dusky.pond.sub.org> <87tvf7d1a6.fsf@dusky.pond.sub.org> From: Thomas Huth Message-ID: <17e16697-2f36-cdf3-4067-a04f5de6b66c@redhat.com> Date: Tue, 9 Apr 2019 10:40:14 +0200 MIME-Version: 1.0 In-Reply-To: <87tvf7d1a6.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Kevin Wolf , Stephen Checkoway , Stephen Checkoway , qemu-block@nongnu.org, Laurent Vivier , qemu-devel@nongnu.org, Max Reitz , Paolo Bonzini On 09/04/2019 10.35, Markus Armbruster wrote: > Thomas Huth writes: > >> On 09/04/2019 09.45, Markus Armbruster wrote: >>> Thomas Huth writes: >>> >>>> We'd like to get rid of global_qtest in the long run (since it is >>>> causing trouble for tests that run multiple instances of QEMU in >>>> parallel, e.g. migration tests)... so if it is feasible, please don't >>>> use it in new code anymore. Try to use a local variable in the function >>>> that call qtest_initf() and pass the test state around via a parameter >>>> to the functions that need it. >>> >>> Twenty tests still use @global_qtest >>> >>> Either we're serious about getting rid of @global_qtest. Then we should >>> just do it. >> >> Ha ha, "just do it" ... that's quite a bit of work, actually. It's not >> just about grep'ing for global_qtest, you also have to replace all the >> writel(), readl() etc. functions with qtest_writel(), qtest_readl() etc. > > And that's precisely why I'm reluctant to demand this work from > contributors. Asking nicely is of course fair. That's what I did, didn't I? I said "... so if it is feasible, please don't use it in new code anymore". I did not say "you must not use this in new code anymore". So where's your problem here, Markus? Stephen, for the records, in case my mail was not clear: I'm fine if you keep the code as it currently is. But I'd be really happy if you could change it to avoid global_qtest. Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DE1BC10F0E for ; Tue, 9 Apr 2019 08:41:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7A4920883 for ; Tue, 9 Apr 2019 08:41:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7A4920883 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:37490 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDmJq-0000ew-8f for qemu-devel@archiver.kernel.org; Tue, 09 Apr 2019 04:41:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDmIu-00009n-Ky for qemu-devel@nongnu.org; Tue, 09 Apr 2019 04:40:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDmIt-0005ef-Ou for qemu-devel@nongnu.org; Tue, 09 Apr 2019 04:40:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46072) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDmIr-0005d9-Gc; Tue, 09 Apr 2019 04:40:25 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6476F3086258; Tue, 9 Apr 2019 08:40:24 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-133.ams2.redhat.com [10.36.116.133]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A8C661998; Tue, 9 Apr 2019 08:40:15 +0000 (UTC) To: Markus Armbruster References: <9409d9bf-c513-d82b-d438-9173fc582d7f@redhat.com> <87mukzei52.fsf@dusky.pond.sub.org> <87tvf7d1a6.fsf@dusky.pond.sub.org> From: Thomas Huth Openpgp: preference=signencrypt Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzRxUaG9tYXMgSHV0 aCA8dGguaHV0aEBnbXguZGU+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIX gAUCUfuWKwIZAQAKCRAu2dd0/nAttbe/EACb9hafyOb2FmhUqeAiBORSsUifFacQ7laVjcgR I4um8CSHvxijYftpkM2EdAtmXIKgbNDpQoXcWLXB9lu9mLgTO4DVT00TRR65ikn3FCWcyT74 ENTOzRKyKLsDCjhXKPblTPIQbYAUCOWElcyAPm0ERd62fA/rKNxgIiNo/l4UODOMoOJm2/Ox ZoTckW68Eqv7k9L7m7j+Hn3hoDTjAmcCBJt+j7pOhzWvCbqoNOIH8C8qvPaNlrba+R/K6jkO 6jZkTbYQpGIofEQJ/TNn38IsNGpI1ALTHWFtoMxp3j2Imz0REO6dRE2fHRN8sVlHgkoeGhmY NbDsDE1jFQOEObFnu0euk//7BXU7tGOHckVAZ8T1smiRPHfQU7UEH2a/grndxJ+PNeM5w7n2 l+FN3cf2KgPotCK2s9MjSdZA7C5e3rFYO8lqiqTJKvc62vqp3e7B0Kjyy5/QtzSOejBij2QL xkKSFNtxIz4MtuxN8e3IDQNxsKry3nF7R4MDvouXlMo6wP9KuyNWb+vFJt9GtbgfDMIFVamp ZfhEWzWRJH4VgksENA4K/BzjEHCcbTUb1TFsiB1VRnBPJ0SqlvifnfKk6HcpkDk6Pg8Q5FOJ gbNHrdgXsm+m/9GF2zUUr+rOlhVbK23TUqKqPfwnD7uxjpakVcJnsVCFqJpZi1F/ga9IN87B TQRR+3lMARAAtp831HniPHb9AuKq3wj83ujZK8lH5RLrfVsB4X1wi47bwo56BqhXpR/zxPTR eOFT0gnbw9UkphVc7uk/alnXMDEmgvnuxv89PwIQX6k3qLABeV7ykJQG/WT5HQ6+2DdGtVw3 2vjYAPiWQeETsgWRRQMDR0/hwp8s8tL/UodwYCScH6Vxx9pdy353L1fK4Bb9G73a+9FPjp9l x+WwKTsltVqSBuSjyZQ3c3EE8qbTidXZxB38JwARH8yN3TX+t65cbBqLl/zRUUUTapHQpUEd yoAsHIml32e4q+3xdLtTdlLi7FgPBItSazcqZPjEcYW73UAuLcmQmfJlQ5PkDiuqcitn+KzH /1pqsTU7QFZjbmSMJyXY0TDErOFuMOjf20b6arcpEqse1V3IKrb+nqqA2azboRm3pEANLAJw iVTwK3qwGRgK5ut6N/Znv20VEHkFUsRAZoOusrIRfR5HFDxlXguAdEz8M/hxXFYYXqOoaCYy 6pJxTjy0Y/tIfmS/g9Bnp8qg9wsrsnk0+XRnDVPak++G3Uq9tJPwpJbyO0vcqEI3vAXkAB7X VXLzvFwi66RrsPUoDkuzj+aCNumtOePDOCpXQGPpKl+l1aYRMN/+lNSk3+1sVuc2C07WnYyE gV/cbEVklPmKrNwu6DeUyD0qI/bVzKMWZAiB1r56hsGeyYcAEQEAAcLBXwQYAQIACQUCUft5 TAIbDAAKCRAu2dd0/nAttYTwEACLAS/THRqXRKb17PQmKwZHerUvZm2klo+lwQ3wNQBHUJAT p2R9ULexyXrJPqjUpy7+voz+FcKiuQBTKyieiIxO46oMxsbXGZ70o3gxjxdYdgimUD6U8PPd JH8tfAL4BR5FZNjspcnscN2jgbF4OrpDeOLyBaj6HPmElNPtECHWCaf1xbIFsZxSDGMA6cUh 0uX3Q8VI7JN1AR2cfiIRY7NrIlWYucJxyKjO3ivWm69nCtsHiJ0wcF8KlVo7F2eLaufo0K8A ynL8SHMF3VEyxsXOP2f1UR9T2Ur30MXcTBpjUxml1TX3RWY5uH89Js/jlIugBwuAmacJ7JYh lTg6sF/GNc4nPb4kk2yktNWTade+TzsllYlJPaorD2Qe8qX0iFUhFC6y9+O6mP4ZvWoYapp9 ezYNuebMgEr93ob1+4sFg3812wNP01WqsGtWCJHnPv/JoonFdMzD/bIkXGEJMk6ks2kxQQZq g6Ik/s/vxOfao/xCn8nHt7GwvVy41795hzK6tbSl+BuyCRp0vfPRP34OnK7+jR2nvQpJu/pU rCELuGwT9hsYkUPjVd4lfylN3mzEc6iAv/wwjsc0DRTSQCpXT3v2ymTAsRKrVaEZLibTXaf+ WslxWek3xNYRiqwwWAJuL652eAlxUgQ5ZS+fXBRTiQpJ+F26I/2lccScRd9G5w== Organization: Red Hat Message-ID: <17e16697-2f36-cdf3-4067-a04f5de6b66c@redhat.com> Date: Tue, 9 Apr 2019 10:40:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87tvf7d1a6.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Tue, 09 Apr 2019 08:40:24 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stephen Checkoway , Stephen Checkoway , qemu-block@nongnu.org, Laurent Vivier , qemu-devel@nongnu.org, Max Reitz , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190409084014.R0z7izyzYA5G8CAWI8M6l7UZ2RoVWseRFHtwEzXSxvs@z> On 09/04/2019 10.35, Markus Armbruster wrote: > Thomas Huth writes: > >> On 09/04/2019 09.45, Markus Armbruster wrote: >>> Thomas Huth writes: >>> >>>> We'd like to get rid of global_qtest in the long run (since it is >>>> causing trouble for tests that run multiple instances of QEMU in >>>> parallel, e.g. migration tests)... so if it is feasible, please don't >>>> use it in new code anymore. Try to use a local variable in the function >>>> that call qtest_initf() and pass the test state around via a parameter >>>> to the functions that need it. >>> >>> Twenty tests still use @global_qtest >>> >>> Either we're serious about getting rid of @global_qtest. Then we should >>> just do it. >> >> Ha ha, "just do it" ... that's quite a bit of work, actually. It's not >> just about grep'ing for global_qtest, you also have to replace all the >> writel(), readl() etc. functions with qtest_writel(), qtest_readl() etc. > > And that's precisely why I'm reluctant to demand this work from > contributors. Asking nicely is of course fair. That's what I did, didn't I? I said "... so if it is feasible, please don't use it in new code anymore". I did not say "you must not use this in new code anymore". So where's your problem here, Markus? Stephen, for the records, in case my mail was not clear: I'm fine if you keep the code as it currently is. But I'd be really happy if you could change it to avoid global_qtest. Thomas