From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcEbT-0007PW-QQ for qemu-devel@nongnu.org; Wed, 16 Sep 2015 11:26:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcEbP-00063A-Cv for qemu-devel@nongnu.org; Wed, 16 Sep 2015 11:26:35 -0400 Received: from mx5-phx2.redhat.com ([209.132.183.37]:44832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcEbP-000631-3u for qemu-devel@nongnu.org; Wed, 16 Sep 2015 11:26:31 -0400 Date: Wed, 16 Sep 2015 11:26:29 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <1803739212.12766841.1442417189143.JavaMail.zimbra@redhat.com> In-Reply-To: <55F989B1.7010409@virtuozzo.com> References: <1442333283-13119-1-git-send-email-marcandre.lureau@redhat.com> <1442333283-13119-43-git-send-email-marcandre.lureau@redhat.com> <55F989B1.7010409@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 42/46] ivshmem: make ivshmem_get_size() more generic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy Cc: marcandre lureau , drjones@redhat.com, cam@cs.ualberta.ca, qemu-devel@nongnu.org, stefanha@redhat.com Hi ----- Original Message ----- > Hi! >=20 > On 15.09.2015 19:07, marcandre.lureau@redhat.com wrote: > > From: Marc-Andr=C3=A9 Lureau > > > > Use a more explicit function name parse_mem_size(). I guess such > > function could be common (or exists already somewhere). >=20 > strtosz() from include/qemu-common.h is appropriate thanks, that's what I was looking for! cheers >=20 > > > > Signed-off-by: Marc-Andr=C3=A9 Lureau > > --- > > hw/misc/ivshmem.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c > > index f9ac955..5fb2123 100644 > > --- a/hw/misc/ivshmem.c > > +++ b/hw/misc/ivshmem.c > > @@ -643,12 +643,12 @@ static void ivshmem_reset(DeviceState *d) > > ivshmem_use_msix(s); > > } > > =20 > > -static uint64_t ivshmem_get_size(IVShmemState * s, Error **errp) { > > - > > +static uint64_t parse_mem_size(const char *sizearg, Error **errp) > > +{ > > uint64_t value; > > char *ptr; > > =20 > > - value =3D strtoull(s->sizearg, &ptr, 10); > > + value =3D strtoull(sizearg, &ptr, 10); > > switch (*ptr) { > > case 0: case 'M': case 'm': > > value <<=3D 20; > > @@ -657,7 +657,7 @@ static uint64_t ivshmem_get_size(IVShmemState * s, > > Error **errp) { > > value <<=3D 30; > > break; > > default: > > - error_setg(errp, "invalid ram size: %s", s->sizearg); > > + error_setg(errp, "invalid ram size: %s", sizearg); > > return 0; > > } > > =20 > > @@ -704,7 +704,7 @@ static void pci_ivshmem_realize(PCIDevice *dev, Err= or > > **errp) > > if (s->sizearg =3D=3D NULL) { > > s->ivshmem_size =3D 4 << 20; /* 4 MB default */ > > } else { > > - s->ivshmem_size =3D ivshmem_get_size(s, &local_err); > > + s->ivshmem_size =3D parse_mem_size(s->sizearg, &local_err); > > if (local_err) { > > error_propagate(errp, local_err); > > return; >=20 >=20 > -- > Best regards, > Vladimir > * now, @virtuozzo.com instead of @parallels.com. Sorry for this > inconvenience. >=20 >=20