From: John Snow <jsnow@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Jason Wang <jasowang@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] trace: Remove trailing newline in events
Date: Mon, 16 Sep 2019 12:41:44 -0400 [thread overview]
Message-ID: <180c6b99-deee-aa8d-01b6-0ec75bab4d70@redhat.com> (raw)
In-Reply-To: <d86629a7-510c-5a33-36f3-f33284e1ba5e@redhat.com>
On 9/16/19 12:40 PM, Philippe Mathieu-Daudé wrote:
> On 9/16/19 6:36 PM, Eric Blake wrote:
>> On 9/16/19 4:51 AM, Philippe Mathieu-Daudé wrote:
>>> While the tracing frawework does not forbid trailing newline in
>>
>> framework
>>
>>> events format string, using them lead to confuse output.
>>> It is the responsibility of the backend to properly end an event
>>> line.
>>
>> Why just trailing newline? Should we not forbid ALL use of newline in a
>> trace message?
>
> I thought about it and forgot to add a comment when respining.
> Yes, I think this is the right thing to enforce.
> However it requires more cleanup, affecting more subsystems, so I'd
> rather keep it for a follow-up series.
What's the problem with using multi-line trace statements?
Does it interfere with non-printf backends?
(I think I intentionally use these for AHCI in a few places.)
--js
next prev parent reply other threads:[~2019-09-16 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 9:51 [Qemu-devel] [PATCH v2 0/2] trace: Forbid trailing newline in event format Philippe Mathieu-Daudé
2019-09-16 9:51 ` [Qemu-devel] [PATCH v2 1/2] trace: Remove trailing newline in events Philippe Mathieu-Daudé
2019-09-16 16:36 ` Eric Blake
2019-09-16 16:40 ` Philippe Mathieu-Daudé
2019-09-16 16:41 ` John Snow [this message]
2019-09-18 9:18 ` Stefan Hajnoczi
2019-09-16 9:51 ` [Qemu-devel] [PATCH v2 2/2] trace: Forbid event format ending with newline character Philippe Mathieu-Daudé
2019-09-18 9:21 ` [Qemu-devel] [Qemu-block] [PATCH v2 0/2] trace: Forbid trailing newline in event format Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=180c6b99-deee-aa8d-01b6-0ec75bab4d70@redhat.com \
--to=jsnow@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).