From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EC6AC433FE for ; Tue, 18 Oct 2022 12:05:31 +0000 (UTC) Received: from localhost ([::1]:37894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oklLd-0001ED-QY for qemu-devel@archiver.kernel.org; Tue, 18 Oct 2022 08:05:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oklBw-00084V-Sr for qemu-devel@nongnu.org; Tue, 18 Oct 2022 07:55:29 -0400 Received: from kylie.crudebyte.com ([5.189.157.229]:38015) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oklBi-0002yf-Aa for qemu-devel@nongnu.org; Tue, 18 Oct 2022 07:55:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=kylie; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=51pI383kLIOgNqBf4bVO/jweqafukty0hmgNo4caaYc=; b=w52Eyvwle1RQDCgUncLwosAJ6b 8EkIVFqprL6isnOjvel+8oBXbBdUqH8ZHjrncbkr+6969aoV6fTA/VBl+7I9OJ8kKw0Y/+amNBZQh S9d5reqoRxL1UVkLBlHeU82MnMXbdRCbTXxo9C6+M+LVlupRiK0EXLv4Tnt+7rqFMP8/27eR0Um4+ eGkNkIya2WN65JqFHZ+sWHk/uWbCX6yq3TPb5nROTqp+fwIrdV+UxZrNQlJqIY9b6wm9FVSlEAHb8 RrZQY6r97AoXLxdkIsY2DaOspS3EAUReL30P/rVAzUBQq6HxamGNpv/F2Tmz8FKqgVWHVo9kqKwfh FzB7J5oawJX4Woxw2pT2l+2virhlEA2zFJ0vYyaP++o//47vlPIKGOgV5dJWOwHcg8IF8sz29NbDq wyqM7G4ZfcxItt1NVWYEvE1K6WIk6/uX83msPwPU2eamuBNdICzH/3UKhfOqdjTkzrkDmYKX5bI+Y 9nZLmO45l7PgVU2okNKO1Dn4LEYFio431K4uhIbKOnGgzBGb8gHQZX2FlnpFr1ppG9VkxnrNHRp/H LlU9lHeBGJwLlWyPaEwmNjW7x6dSOIrd/NdtQyAREAnzb3AFHekrbPreyJRpSr1Fj6vOU1eHODgAm vUz2IINvgOJmz46yF0W0gi3QSRF0KgY10azofl1fQ=; From: Christian Schoenebeck To: qemu-devel@nongnu.org Cc: Greg Kurz , Laurent Vivier , Thomas Huth Subject: Re: [PATCH 00/20] tests/9p: introduce declarative function calls Date: Tue, 18 Oct 2022 13:54:58 +0200 Message-ID: <1813122.qVG7zHTq9q@silver> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: pass client-ip=5.189.157.229; envelope-from=qemu_oss@crudebyte.com; helo=kylie.crudebyte.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tuesday, October 4, 2022 10:56:44 PM CEST Christian Schoenebeck wrote: > This series converts relevant 9p (test) client functions to use named > function arguments. For instance > > do_walk_expect_error(v9p, "non-existent", ENOENT); > > becomes > > twalk({ > .client = v9p, .path = "non-existent", .expectErr = ENOENT > }); > > The intention is to make the actual 9p test code more readable, and easier > to maintain on the long-term. > > Not only makes it clear what a literal passed to a function is supposed to > do, it also makes the order and selection of arguments very liberal, and > allows to merge multiple, similar functions into one single function. > > This is basically just refactoring, it does not change behaviour. Queued on 9p.next: https://github.com/cschoenebeck/qemu/commits/9p.next Thanks! Next 9p PR end of this week. Best regards, Christian Schoenebeck