From: Marcel Apfelbaum <marcel@redhat.com>
To: Kashyap Chamarthy <kchamart@redhat.com>, qemu-devel@nongnu.org
Cc: mst@redhat.com, berrange@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] docs: pcie: Spell out machine type needs for PCIe features
Date: Mon, 19 Feb 2018 19:39:43 +0200 [thread overview]
Message-ID: <18297a0f-595e-2dcc-7f70-82c4430aa374@redhat.com> (raw)
In-Reply-To: <20180219163131.31153-1-kchamart@redhat.com>
On 19/02/2018 18:31, Kashyap Chamarthy wrote:
> PCIe features are available only via the 'q35' machine type for x86 and
> the 'virt' machine type for AArch64 architecture.
>
> Mention that explicitly.
Thanks for the improvement
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Thanks,
Marcel
>
> Thanks: Daniel Berrangé
>
> Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
> ---
> docs/pcie.txt | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/docs/pcie.txt b/docs/pcie.txt
> index 8d3694970e..89e3502075 100644
> --- a/docs/pcie.txt
> +++ b/docs/pcie.txt
> @@ -3,8 +3,13 @@ PCI EXPRESS GUIDELINES
>
> 1. Introduction
> ================
> -The doc proposes best practices on how to use PCI Express/PCI device
> -in PCI Express based machines and explains the reasoning behind them.
> +The doc proposes best practices on how to use PCI Express (PCIe) / PCI
> +devices in PCI Express based machines and explains the reasoning behind
> +them.
> +
> +Note that the PCIe features are available only when using the 'q35'
> +machine type on x86 architecture and the 'virt' machine type on AArch64.
> +Other machine types do not use PCIe at this time.
>
> The following presentations accompany this document:
> (1) Q35 overview.
>
prev parent reply other threads:[~2018-02-19 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 16:31 [Qemu-devel] [PATCH v2] docs: pcie: Spell out machine type needs for PCIe features Kashyap Chamarthy
2018-02-19 16:33 ` Daniel P. Berrangé
2018-02-19 17:39 ` Marcel Apfelbaum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18297a0f-595e-2dcc-7f70-82c4430aa374@redhat.com \
--to=marcel@redhat.com \
--cc=berrange@redhat.com \
--cc=kchamart@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).