From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1enpQ5-0003n9-ER for qemu-devel@nongnu.org; Mon, 19 Feb 2018 12:40:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1enpQ1-0002fj-9G for qemu-devel@nongnu.org; Mon, 19 Feb 2018 12:40:05 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:54414 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1enpQ1-0002fG-4g for qemu-devel@nongnu.org; Mon, 19 Feb 2018 12:40:01 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 26DC28424D for ; Mon, 19 Feb 2018 17:39:50 +0000 (UTC) References: <20180219163131.31153-1-kchamart@redhat.com> From: Marcel Apfelbaum Message-ID: <18297a0f-595e-2dcc-7f70-82c4430aa374@redhat.com> Date: Mon, 19 Feb 2018 19:39:43 +0200 MIME-Version: 1.0 In-Reply-To: <20180219163131.31153-1-kchamart@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] docs: pcie: Spell out machine type needs for PCIe features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kashyap Chamarthy , qemu-devel@nongnu.org Cc: mst@redhat.com, berrange@redhat.com On 19/02/2018 18:31, Kashyap Chamarthy wrote: > PCIe features are available only via the 'q35' machine type for x86 and > the 'virt' machine type for AArch64 architecture. >=20 > Mention that explicitly. Thanks for the improvement Reviewed-by: Marcel Apfelbaum Thanks, Marcel >=20 > Thanks: Daniel Berrang=C3=A9 >=20 > Signed-off-by: Kashyap Chamarthy > --- > docs/pcie.txt | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >=20 > diff --git a/docs/pcie.txt b/docs/pcie.txt > index 8d3694970e..89e3502075 100644 > --- a/docs/pcie.txt > +++ b/docs/pcie.txt > @@ -3,8 +3,13 @@ PCI EXPRESS GUIDELINES > =20 > 1. Introduction > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > -The doc proposes best practices on how to use PCI Express/PCI device > -in PCI Express based machines and explains the reasoning behind them. > +The doc proposes best practices on how to use PCI Express (PCIe) / PCI > +devices in PCI Express based machines and explains the reasoning behin= d > +them. > + > +Note that the PCIe features are available only when using the 'q35' > +machine type on x86 architecture and the 'virt' machine type on AArch6= 4. > +Other machine types do not use PCIe at this time. > =20 > The following presentations accompany this document: > (1) Q35 overview. >=20