From: Michal Privoznik <mprivozn@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: jingqi.liu@intel.com, tao3.xu@intel.com, qemu-devel@nongnu.org,
ehabkost@redhat.com
Subject: Re: [PATCH 2/3] numa: Allow HMAT cache to be defined before HMAT latency/bandwidth
Date: Fri, 29 May 2020 17:22:20 +0200 [thread overview]
Message-ID: <182c849b-0f0f-9393-f1db-fba9bb885d6a@redhat.com> (raw)
In-Reply-To: <20200529165947.36a8cf55@redhat.com>
On 5/29/20 4:59 PM, Igor Mammedov wrote:
> On Fri, 29 May 2020 15:33:47 +0200
> Michal Privoznik <mprivozn@redhat.com> wrote:
>
>> Currently, when defining a HMAT cache for a NUMA node (in
>> parse_numa_hmat_cache()) there is this check that forces users to
>> define HMAT latency/bandwidth first. There is no real need for
>> this, because nothing in the parse function relies on that and
>> the HMAT table is constructed way later - when ACPI table is
>> constructed.
>
> see comment in
> https://lists.gnu.org/archive/html/qemu-devel/2019-11/msg01206.html
>
> in short doing check at this time allow us not to have more complex
> check later on.
>
> perhaps it needs a comment so that later it won't be dropped by accident
Fair enough. Discard this one then and I will post a patch that document
this.
Michal
next prev parent reply other threads:[~2020-05-29 15:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 13:33 [PATCH 0/3] Couple of HMAT fixes Michal Privoznik
2020-05-29 13:33 ` [PATCH 1/3] qapi: Make @associativity, @policy and @line of NumaHmatCacheOptions optional Michal Privoznik
2020-05-29 15:25 ` Igor Mammedov
2020-05-29 13:33 ` [PATCH 2/3] numa: Allow HMAT cache to be defined before HMAT latency/bandwidth Michal Privoznik
2020-05-29 14:59 ` Igor Mammedov
2020-05-29 15:22 ` Michal Privoznik [this message]
2020-05-29 13:33 ` [PATCH 3/3] numa: Initialize node initiator with respect to .has_cpu Michal Privoznik
2020-05-29 15:09 ` Igor Mammedov
2020-05-29 15:24 ` Michal Privoznik
2020-06-01 8:10 ` Michal Privoznik
2020-06-02 8:00 ` Tao Xu
2020-06-03 9:16 ` Michal Privoznik
2020-06-05 1:52 ` Tao Xu
2020-06-11 14:42 ` Michal Privoznik
2020-05-29 20:11 ` [PATCH 0/3] Couple of HMAT fixes no-reply
2020-05-29 20:42 ` no-reply
2020-06-01 11:14 ` Michal Privoznik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=182c849b-0f0f-9393-f1db-fba9bb885d6a@redhat.com \
--to=mprivozn@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jingqi.liu@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=tao3.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).