Re: [RFC PATCH v3 10/34] Hexagon (target/hexagon) instruction and packet types

[Richard Henderson <richard.henderson@linaro.org>]

On 8/18/20 8:50 AM, Taylor Simpson wrote:
> +struct Instruction {
> +    semantic_insn_t generate;            /* pointer to genptr routine */
> +    size1u_t regno[REG_OPERANDS_MAX];    /* reg operands including predicates */
> +    size2u_t opcode;
> +
> +    size4u_t iclass:6;
> +    size4u_t slot:3;
> +    size4u_t part1:1;        /*
> +                              * cmp-jumps are split into two insns.
> +                              * set for the compare and clear for the jump
> +                              */
> +    size4u_t extension_valid:1;   /* Has a constant extender attached */
> +    size4u_t which_extended:1;    /* If has an extender, which immediate */
> +    size4u_t is_endloop:1;   /* This is an end of loop */
> +    size4u_t new_value_producer_slot:4;
> +    size4s_t immed[IMMEDS_MAX];    /* immediate field */
> +};

Is this an imported file or not?

If it is not imported, I'd very much prefer that we stick to the stdint.h type
names.


r~