From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: el13635@mail.ntua.gr, kwolf@redhat.com, berrange@redhat.com,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] vl: Factor object_create() out of main()
Date: Thu, 10 Aug 2017 09:43:46 -0500 [thread overview]
Message-ID: <1837a5c7-92a2-a40a-5f96-21bd448790bd@redhat.com> (raw)
In-Reply-To: <1502367921-17730-2-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
On 08/10/2017 07:25 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> vl.c | 21 ++++++++++-----------
> 1 file changed, 10 insertions(+), 11 deletions(-)
>
> +++ b/vl.c
> @@ -2845,7 +2845,6 @@ static bool object_create_initial(const char *type)
> return true;
> }
>
> -
> /*
Spurious whitespace change? I can live with it because it adds
consistency, but it's not on a function directly touched by this patch.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-08-10 14:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 12:25 [Qemu-devel] [PATCH 0/2] vl: Partial support for non-scalar properties with -object Markus Armbruster
2017-08-10 12:25 ` [Qemu-devel] [PATCH 1/2] vl: Factor object_create() out of main() Markus Armbruster
2017-08-10 14:43 ` Eric Blake [this message]
2017-08-10 16:28 ` Markus Armbruster
2017-08-11 3:33 ` Philippe Mathieu-Daudé
2017-08-10 12:25 ` [Qemu-devel] [PATCH 2/2] vl: Partial support for non-scalar properties with -object Markus Armbruster
2017-08-10 14:59 ` Eric Blake
2017-08-10 16:33 ` Markus Armbruster
2017-08-10 15:02 ` Paolo Bonzini
2017-08-10 16:36 ` Markus Armbruster
2017-08-10 16:38 ` Paolo Bonzini
2017-08-11 6:20 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1837a5c7-92a2-a40a-5f96-21bd448790bd@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=el13635@mail.ntua.gr \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).