Re: [Qemu-devel] [PATCH v9 13/13] iotests: add dirty bitmap postcopy test

[Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>]

20.01.2018 03:37, John Snow wrote:
>
> On 01/19/2018 01:08 PM, Vladimir Sementsov-Ogievskiy wrote:
>> 18.01.2018 12:57, Vladimir Sementsov-Ogievskiy wrote:
>>> 17.01.2018 21:30, John Snow wrote:
>>>> On 12/28/2017 06:49 AM, Vladimir Sementsov-Ogievskiy wrote:
>>>>> Thank you for reviewing my code!
>>>>>
>>>> Time for the re-spin? There's pretty good pressure to get this into 2.12
>>>> and say the non-nbd workflow model is feature complete.
>>> Yes, you are right. Hope to do it today or tomorrow.
>>>
>> I've rebased, applied comments from review, and even one some new fixes,
>> but now I understand that it is too early for re-spin.
>>
>> Now this series depends on
>> 1. [PATCH v2 0/3] fix bitmaps migration through shared storage
>>    - we need to decide, how to fix it. May be, we just do not need
>> bitmaps in inactive state, and should not load them in do_qcow2_open in
>> this case
>>    [I can ignore it, just dropping one test case from new iotest, and fix
>> it later, but..
> I'll look at this next.
>
>> 2. [PATCH v2 0/6] qmp dirty bitmap API
>>   - here autoload is dropped, and migration should be rebased on it.
>>
> For (2) I really want to see a test case showing the utility for enable,
> disable and merge to be added to the API, *or* add an x- prefix to them
> for now.

tests are inevitable, I'll make them)

>
> I want to see some use-case tests that demonstrate how they are to be
> safely used, basically. You might want to expand test 124 for this.
>
> I'm not sure we need this entire series for migration, but I don't want
> to make you re-order absolutely everything. Can we merge patch one by
> itself for the purposes of the migration patchset?

I think yes, will try.

>> so, I'll re-spin migration after these two questions are resolved.
>>
> Thanks for your patience, as always. Please send me pings every day on
> whatever you have to in order to get migration in to 2.12 -- I'm going
> to try to stay focused too, but I've got the attention span of a
> goldfish. If I miss something, please speak up.
>
> --js


-- 
Best regards,
Vladimir