From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Greg Kurz <groug@kaod.org>, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] 9pfs: drop Doxygen format from qemu_dirent_dup() API comment
Date: Thu, 03 Mar 2022 11:55:36 +0100 [thread overview]
Message-ID: <1847380.I5uLlGeFOO@silver> (raw)
In-Reply-To: <20220303105332.5ce078a9@bahia>
On Donnerstag, 3. März 2022 10:53:32 CET Greg Kurz wrote:
> On Wed, 2 Mar 2022 19:30:39 +0100
>
> Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> > API doc comments in QEMU are supposed to be in kerneldoc format, so drop
> > occurrences of "@c" which is Doxygen format for fixed-width text.
> >
> > Link:
> > https://lore.kernel.org/qemu-devel/CAFEAcA89+ENOM6x19OEF53Kd2DWkhN5SN21Va
> > 0D7yepJSa3Jyg@mail.gmail.com/ Based-on:
> > <E1nP9Oz-00043L-KJ@lizzy.crudebyte.com>
> > Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> > ---
>
> Sorry for not catching these during previous reviews :-\
>
> Reviewed-by: Greg Kurz <groug@kaod.org>
>
> FWIW it seems some more de-doxygenation is needed :
>
> fsdev/p9array.h: * Consider the following user struct @c Foo which shall be
> used as scalar fsdev/p9array.h: * @code
> fsdev/p9array.h: * and assume it has the following function to free memory
> allocated by @c Foo fsdev/p9array.h: * @code
> fsdev/p9array.h: * @code
> fsdev/p9array.h: * @code
> fsdev/p9array.h: * @code
> hw/9pfs/9p.h: * Lenght of the affix, that is how many (of the lowest)
> bits of @c value extra nit ^^
> hw/9pfs/codir.c: * @note You must @b ALWAYS call @c
> v9fs_free_dirents(entries) after calling
OK, I send more patches to wipe these as well today.
Greg, if something is tagged as junk email at your end, please remove it from
the subject line, otherwise I will not receive your reply. It was pure luck
that I noticed your message on the archives this time.
Best regards,
Christian Schoenebeck
next prev parent reply other threads:[~2022-03-03 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 18:30 [PATCH] 9pfs: drop Doxygen format from qemu_dirent_dup() API comment Christian Schoenebeck
2022-03-02 18:57 ` Peter Maydell
2022-03-03 9:53 ` [SPAM] " Greg Kurz
2022-03-03 10:55 ` Christian Schoenebeck [this message]
2022-03-03 11:29 ` Greg Kurz
2022-03-03 12:22 ` Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1847380.I5uLlGeFOO@silver \
--to=qemu_oss@crudebyte.com \
--cc=groug@kaod.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).