From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Kevin Wolf <kwolf@suse.de>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] open ptys in non-blocking mode.
Date: Fri, 18 Jul 2008 14:56:39 +0100 [thread overview]
Message-ID: <18560.41239.807136.765308@mariner.uk.xensource.com> (raw)
In-Reply-To: <4880574C.1020703@suse.de>
Kevin Wolf writes ("Re: [Qemu-devel] [PATCH 2/2] open ptys in non-blocking mode."):
> Ian, we need something like this for qemu-xen (or ioemu-remote or
> whatever it's called now). Currently you must attach to the console of a
> domain, otherwise it won't boot up and keep hanging in a blocking write
> because the buffer is full.
Yes, that's right. See my other messages, including the patches which
will be arriving shortly ...
> The old ioemu had a hack in unix_write (doing a select before the write)
> which you didn't merge into qemu-xen. In fact, I noticed that you even
> removed that function entirely and I'm wondering why.
We have qemu_{read,write} instead, as I wrote in January. Those make
it easy to have good error handling. Sadly my patch from January
wasn't accepted upstream.
Ian.
next prev parent reply other threads:[~2008-07-18 13:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 12:19 [Qemu-devel] [PATCH 1/2] unix_write: don't block on non-blocking file handles Gerd Hoffmann
2008-07-09 12:19 ` [Qemu-devel] [PATCH 2/2] open ptys in non-blocking mode Gerd Hoffmann
2008-07-18 8:41 ` Kevin Wolf
2008-07-18 9:10 ` Gerd Hoffmann
2008-07-18 9:14 ` Kevin Wolf
2008-07-18 13:56 ` Ian Jackson [this message]
2008-07-18 13:47 ` Ian Jackson
2008-07-18 13:46 ` [Qemu-devel] [PATCH 1/2] unix_write: don't block on non-blocking file handles Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18560.41239.807136.765308@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=kraxel@redhat.com \
--cc=kwolf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).