From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4F8DC433F5 for ; Tue, 8 Mar 2022 17:33:25 +0000 (UTC) Received: from localhost ([::1]:37274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nRdi6-00086c-31 for qemu-devel@archiver.kernel.org; Tue, 08 Mar 2022 12:33:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRddy-0003fl-HI; Tue, 08 Mar 2022 12:29:08 -0500 Received: from [2607:f8b0:4864:20::534] (port=41897 helo=mail-pg1-x534.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nRddw-0002LH-Ar; Tue, 08 Mar 2022 12:29:06 -0500 Received: by mail-pg1-x534.google.com with SMTP id o26so17053423pgb.8; Tue, 08 Mar 2022 09:29:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=qxdFXVmVFLrUNzeiFEMfLxJLZee/tN10m8g+e68eLwc=; b=KN9IJNzFzDGO/tmSRPw/i1ORFTIYoTtDnUnKqUnFarqF+CNgKW2xUwQh7nXVxIymIr 6kn1473+Of3njX0pR5aT8o668szL4CTf8W+A6SLsxOPPo1+aQGteXKSqmoBz97IWdZ3+ PB9/sO5LdrHbvhSkooteERnMWBPTUVFLTZo25aixcZDBNvatBiIoWglZOCzLjq/md/g0 xMcvF/Zxe1wB8tM8X1lH61KgpRT3s8qQTM45GDPonBZZqKg7uEbsb7JFeivsNriq21C+ Xc6tGWvXt5vILXkDt6wjSGCcA76NLxah16pLoGoEKJnl26x7+fQq/cWpwawh/zRL054L 6NTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=qxdFXVmVFLrUNzeiFEMfLxJLZee/tN10m8g+e68eLwc=; b=AJFCcGYDnHZoRfkWvFUpdqo7ClYyu0E+F2C0HPiY8MQhatfNfUWdmt83qx93N9evvo ew4riQw3rqU4/peMWpZX8Fji0sun+CcMZTZVtbyGOOmhYqIJ8dRSc9BvNLlvxbR+bvOu ytvlE2srgnLkODmIon9/s7U00Wvu4iTHjB7gStzzTGWeR3/nElemyvR46unIuEcmb8/u LHr8lSZ/BJBPJbATFmz8wsyzzRaB8OOQYQIc3p6efK9VE1vCQBxAdxSN2HQOxaO4x3Vs REJBoH53ZCY1TYC86D1iW/BQ8laHwOND774D0/JxkNtk7QcXcZpWrb5wnV/kvm6sPVIv gKgw== X-Gm-Message-State: AOAM533T344Ax9loohir4IXm/+pRXnIhXQQfLhnH6eC6ZAwrNisZtusc GFi2YbspVYqdU0GCE24vVjU= X-Google-Smtp-Source: ABdhPJxSEccff/tBjKgcVJs1y5HcyPFpfvNz7py6yyKlUDfzMgOcwuWo2hQDhuMsrCoMMUA3oXej9w== X-Received: by 2002:a63:5c5b:0:b0:380:d9f:df20 with SMTP id n27-20020a635c5b000000b003800d9fdf20mr13200220pgm.278.1646760541796; Tue, 08 Mar 2022 09:29:01 -0800 (PST) Received: from [192.168.1.35] (71.red-83-50-68.dynamicip.rima-tde.net. [83.50.68.71]) by smtp.gmail.com with ESMTPSA id p16-20020a056a000b5000b004f669806cd9sm21239499pfo.87.2022.03.08.09.28.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Mar 2022 09:29:01 -0800 (PST) Message-ID: <1856bc98-73f8-82af-b8e7-cdc88161774b@gmail.com> Date: Tue, 8 Mar 2022 18:28:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] hw/misc/npcm7xx_clk: Don't leak string in npcm7xx_clk_sel_init() Content-Language: en-US To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20220308170302.2582820-1-peter.maydell@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20220308170302.2582820-1-peter.maydell@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::534 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::534; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-pg1-x534.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tyrone Ting , Havard Skinnemoen Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/3/22 18:03, Peter Maydell wrote: > In npcm7xx_clk_sel_init() we allocate a string with g_strdup_printf(). > Use g_autofree so we free it rather than leaking it. > > (Detected with the clang leak sanitizer.) > > Signed-off-by: Peter Maydell > --- > hw/misc/npcm7xx_clk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé