From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53304C47E49 for ; Wed, 6 Nov 2019 11:19:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 262622077C for ; Wed, 6 Nov 2019 11:19:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 262622077C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=proxmox.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSJLP-0003HG-2r for qemu-devel@archiver.kernel.org; Wed, 06 Nov 2019 06:19:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33248) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSJKI-0001xp-9b for qemu-devel@nongnu.org; Wed, 06 Nov 2019 06:18:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSJKG-0001Bo-9j for qemu-devel@nongnu.org; Wed, 06 Nov 2019 06:18:14 -0500 Received: from proxmox-new.maurer-it.com ([212.186.127.180]:48851) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iSJK7-0000cv-DT; Wed, 06 Nov 2019 06:18:03 -0500 Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 24825464D5; Wed, 6 Nov 2019 12:18:01 +0100 (CET) Date: Wed, 6 Nov 2019 12:18:00 +0100 (CET) From: Dietmar Maurer To: Max Reitz , Wolfgang Bumiller Message-ID: <1868807950.27.1573039080274@webmail.proxmox.com> In-Reply-To: <37f72cb7-7085-3c40-7728-e41d59137b3b@redhat.com> References: <1767781109.66.1572948164492@webmail.proxmox.com> <20191106083222.GA189998@stefanha-x1.localdomain> <20191106103450.cafwk7m5xd5eulxo@olga.proxmox.com> <37f72cb7-7085-3c40-7728-e41d59137b3b@redhat.com> Subject: Re: backup_calculate_cluster_size does not consider source MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.2-Rev15 X-Originating-Client: open-xchange-appsuite X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.186.127.180 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Dietmar Maurer Cc: Kevin Wolf , Stefan Hajnoczi , "qemu-devel@nongnu.org" , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > And if it issues a smaller request, there is no way for a guest device > to tell it =E2=80=9COK, here=E2=80=99s your data, but note we have a whol= e 4 MB chunk > around it, maybe you=E2=80=99d like to take that as well...?=E2=80=9D >=20 > I understand wanting to increase the backup buffer size, but I don=E2=80= =99t > quite understand why we=E2=80=99d want it to increase to the source clust= er size > when the guest also has no idea what the source cluster size is. Because it is more efficent.