qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <mlureau@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org,
	marcandre lureau <marcandre.lureau@redhat.com>,
	eblake@redhat.com, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH for-2.9 6/6] qapi2texi: Fix translation of *strong* and _emphasized_
Date: Mon, 20 Mar 2017 09:32:08 -0400 (EDT)	[thread overview]
Message-ID: <1870195462.9856771.1490016728266.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1490015515-25851-7-git-send-email-armbru@redhat.com>



----- Original Message -----
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

weird this disparity went so far unnoticed

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


> ---
>  scripts/qapi2texi.py            | 4 ++--
>  tests/qapi-schema/doc-good.texi | 8 ++++----
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/scripts/qapi2texi.py b/scripts/qapi2texi.py
> index 5c4db78..9e01500 100755
> --- a/scripts/qapi2texi.py
> +++ b/scripts/qapi2texi.py
> @@ -35,12 +35,12 @@ EXAMPLE_FMT = """@example
>  
>  def subst_strong(doc):
>      """Replaces *foo* by @strong{foo}"""
> -    return re.sub(r'\*([^*\n]+)\*', r'@emph{\1}', doc)
> +    return re.sub(r'\*([^*\n]+)\*', r'@strong{\1}', doc)
>  
>  
>  def subst_emph(doc):
>      """Replaces _foo_ by @emph{foo}"""
> -    return re.sub(r'\b_([^_\n]+)_\b', r' @emph{\1} ', doc)
> +    return re.sub(r'\b_([^_\n]+)_\b', r'@emph{\1}', doc)
>  
>  
>  def subst_vars(doc):
> diff --git a/tests/qapi-schema/doc-good.texi
> b/tests/qapi-schema/doc-good.texi
> index 1160aaf..c410626 100644
> --- a/tests/qapi-schema/doc-good.texi
> +++ b/tests/qapi-schema/doc-good.texi
> @@ -2,7 +2,7 @@
>  
>  @subsection Subsection
>  
> -@emph{strong}  @emph{with emphasis}
> +@strong{strong} @emph{with emphasis}
>  @code{var} @{in braces@}
>  @itemize @bullet
>  @item
> @@ -67,7 +67,7 @@ Example:
>  Examples:
>  @itemize @minus
>  @item
> -@emph{verbatim}
> +@strong{verbatim}
>  @item
>  @{braces@}
>  @end itemize
> @@ -76,12 +76,12 @@ Examples:
>  
>  @deftp {Enum} Enum
>  
> -@subsection Produces @emph{invalid} texinfo
> +@subsection Produces @strong{invalid} texinfo
>  
>  @b{Values:}
>  @table @asis
>  @item @code{one}
> -The  @emph{one}  @{and only@}
> +The @emph{one} @{and only@}
>  @item @code{two}
>  Not documented
>  @end table
> --
> 2.7.4
> 
> 

  reply	other threads:[~2017-03-20 13:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-20 13:11 [Qemu-devel] [PATCH for-2.9 0/6] qapi: Small qapi2texi fixes and addition tests Markus Armbruster
2017-03-20 13:11 ` [Qemu-devel] [PATCH for-2.9 1/6] qapi: Drop excessive Make dependencies on qapi2texi.py Markus Armbruster
2017-03-20 13:17   ` Marc-André Lureau
2017-03-20 13:11 ` [Qemu-devel] [PATCH for-2.9 2/6] qapi2texi: Fix to actually fail when 'doc-required' is false Markus Armbruster
2017-03-20 13:18   ` Marc-André Lureau
2017-03-20 13:11 ` [Qemu-devel] [PATCH for-2.9 3/6] qapi: Drop unused QAPIDoc member optional Markus Armbruster
2017-03-20 13:24   ` Marc-André Lureau
2017-03-20 13:11 ` [Qemu-devel] [PATCH for-2.9 4/6] tests/qapi-schema: Make test-qapi.py print docs again Markus Armbruster
2017-03-20 13:27   ` Marc-André Lureau
2017-03-21  7:18     ` Markus Armbruster
2017-03-20 13:11 ` [Qemu-devel] [PATCH for-2.9 5/6] tests/qapi-schema: Systematic positive doc comment tests Markus Armbruster
2017-03-20 13:28   ` Marc-André Lureau
2017-03-21  7:19     ` Markus Armbruster
2017-03-20 13:11 ` [Qemu-devel] [PATCH for-2.9 6/6] qapi2texi: Fix translation of *strong* and _emphasized_ Markus Armbruster
2017-03-20 13:32   ` Marc-André Lureau [this message]
2017-03-20 13:37     ` Peter Maydell
2017-03-21  7:20       ` Markus Armbruster
2017-03-28 13:24 ` [Qemu-devel] [PATCH for-2.9 0/6] qapi: Small qapi2texi fixes and addition tests no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1870195462.9856771.1490016728266.JavaMail.zimbra@redhat.com \
    --to=mlureau@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).