From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwRll-0002q1-T6 for qemu-devel@nongnu.org; Tue, 18 Oct 2016 06:37:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwRlk-00076I-W2 for qemu-devel@nongnu.org; Tue, 18 Oct 2016 06:37:17 -0400 From: Pino Toscano Date: Tue, 18 Oct 2016 12:36:54 +0200 Message-ID: <18718737.5q2WBcuvP0@thyrus.usersys.redhat.com> In-Reply-To: <20161018094426.GC4706@noname.str.redhat.com> References: <1476782280-3383-1-git-send-email-ptoscano@redhat.com> <20161018094426.GC4706@noname.str.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2648298.6dzIfKAppK"; micalg="pgp-sha256"; protocol="application/pgp-signature" Subject: Re: [Qemu-devel] [PATCH] qapi: fix memory leak in bdrv_image_info_specific_dump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, armbru@redhat.com, mreitz@redhat.com --nextPart2648298.6dzIfKAppK Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Tuesday, 18 October 2016 11:44:26 CEST Kevin Wolf wrote: > Am 18.10.2016 um 11:18 hat Pino Toscano geschrieben: > > The 'obj' result of the visitor was not properly freed, like done in > > other places doing a similar job. > > --- > > block/qapi.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/block/qapi.c b/block/qapi.c > > index 6f947e3..50d3090 100644 > > --- a/block/qapi.c > > +++ b/block/qapi.c > > @@ -698,6 +698,7 @@ void bdrv_image_info_specific_dump(fprintf_function func_fprintf, void *f, > > assert(qobject_type(obj) == QTYPE_QDICT); > > data = qdict_get(qobject_to_qdict(obj), "data"); > > dump_qobject(func_fprintf, f, 1, data); > > + qobject_decref(obj); > > visit_free(v); > > } > > The change looks good, but without a Signed-off-by line I can't accept > the patch: http://wiki.qemu.org/Contribute/SubmitAPatch D'oh, sorry -- apparently I didn't send the right version... v2 coming. Thanks, -- Pino Toscano --nextPart2648298.6dzIfKAppK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYBftGAAoJEMPRTC2YZDfNqYoP/jiOSJWZFwZVq5CAK5cy8U8Y ZGbccUojFfx14pl9B7fnPGeeDYfkKpGFofZzqvOo0I/oXGRHr903+RAfXsWFLx1G tRDhSTuMssaSxe8ty5K+IHrkOuaZ0Rc1NAUsbQmLLwegVP45klrQMSjeZHM7LM75 ldYukKz+zKKe88Dl2QKomHukkwjO1+E//cKjQlpoiUS2dvbP7O+kExOm6cWd4C5q 7KfNA1DMRPRebpimVhZLNwNYxoRamUiet6Y5R/cY13jAZ2D7WVKNOiXWtJUntFDW Hgh7esI7gWckveyNuBCK9/GiBPBSw6/cpxPPOZGo2/tKql8fHt+hPzKH5RavYT9J qt/n6auiYfh20TmhvnEnnystZiSfjYFtuhcM3YXvWWFtFvC2D/8b7ne+QDaRDdec yp2OVKRbPZWlropfP2RL2/CRpwJMcB56CtuGEBREUGPbbblByUY4Kndy3oO4vQmT 8Tq25gES2lB+SX5vQcoIm8j3NTPekkRm6s5FzMm0ZA855Z0hDRHE3S/aK6PBuKK3 KZMw3u/cbLohPOphwCPKp8DMtPMmqdBCJGHktmwIlpUVk+kXdjMWnlNtDKb0tL9s 1ksyoEuRtlf+/9WltaALuwK0uw3kLdf8QpoIyNQTh4J9lP4poDpCweHJsfEr2OoG NrwUHTGX02GEeYWFH8Zp =fq5d -----END PGP SIGNATURE----- --nextPart2648298.6dzIfKAppK--