From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6NYs-0002A4-1I for qemu-devel@nongnu.org; Mon, 14 Nov 2016 15:09:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6NYr-0006pi-1o for qemu-devel@nongnu.org; Mon, 14 Nov 2016 15:09:01 -0500 References: <1478715476-132280-1-git-send-email-vsementsov@virtuozzo.com> <1478715476-132280-3-git-send-email-vsementsov@virtuozzo.com> From: John Snow Message-ID: <187981fd-d195-d0e8-028b-430cb5abf165@redhat.com> Date: Mon, 14 Nov 2016 15:08:52 -0500 MIME-Version: 1.0 In-Reply-To: <1478715476-132280-3-git-send-email-vsementsov@virtuozzo.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/21] specs/qcow2: do not use wording 'bitmap header' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, den@openvz.org On 11/09/2016 01:17 PM, Vladimir Sementsov-Ogievskiy wrote: > A bitmap directory entry is sometimes called a 'bitmap header'. This > patch leaves only one name - 'bitmap directory entry'. The name 'bitmap > header' creates misunderstandings with 'qcow2 header' and 'qcow2 bitmap > header extension' (which is extension of qcow2 header) > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Eric Blake > --- > docs/specs/qcow2.txt | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt > index dda53dd..8874e8c 100644 > --- a/docs/specs/qcow2.txt > +++ b/docs/specs/qcow2.txt > @@ -201,7 +201,7 @@ The fields of the bitmaps extension are: > > 8 - 15: bitmap_directory_size > Size of the bitmap directory in bytes. It is the cumulative > - size of all (nb_bitmaps) bitmap headers. > + size of all (nb_bitmaps) bitmap directory entries. > > 16 - 23: bitmap_directory_offset > Offset into the image file at which the bitmap directory > @@ -426,8 +426,7 @@ Each bitmap saved in the image is described in a bitmap directory entry. The > bitmap directory is a contiguous area in the image file, whose starting offset > and length are given by the header extension fields bitmap_directory_offset and > bitmap_directory_size. The entries of the bitmap directory have variable > -length, depending on the lengths of the bitmap name and extra data. These > -entries are also called bitmap headers. > +length, depending on the lengths of the bitmap name and extra data. > > Structure of a bitmap directory entry: > > Great improvement. Reviewed-by: John Snow