From: Dietmar Maurer <dietmar@proxmox.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 2/3] add vnc h264 encoder
Date: Tue, 8 Apr 2025 11:53:07 +0200 (CEST) [thread overview]
Message-ID: <1880642940.1156.1744105987725@webmail.proxmox.com> (raw)
In-Reply-To: <CAMxuvaxs+qM3msR-tdCXZfMZkQvHqNbHhHwhYKBPtRPLZGyuMA@mail.gmail.com>
> Please resend the series with a cover letter
> (https://www.qemu.org/docs/master/devel/submitting-a-patch.html#use-git-format-patch)
Ok, just resend this series with a cover letter and commit message.
(patches unchanged)
> > +#include <gst/gst.h>
> > +
> > +static void libavcodec_destroy_encoder_context(VncState *vs)
>
> it's not libavcodec.
I will fix that in v2.
> > +#ifdef CONFIG_GSTREAMER
> > + case VNC_ENCODING_H264:
> > + if (vnc_h264_encoder_init(vs) == 0) {
> > + vnc_set_feature(vs, VNC_FEATURE_H264);
>
> Before advertising support for the codec, it should actually check if
> the encoder is present.
ok.
> It would also be useful to have an extra VNC
> option like H264=on/off/auto.
I thought it would be better to do that at the client?
next prev parent reply other threads:[~2025-04-08 9:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 10:59 [PATCH 1/3] new configure option to enable gstreamer Dietmar Maurer
2025-04-07 10:59 ` [PATCH 2/3] add vnc h264 encoder Dietmar Maurer
2025-04-07 20:36 ` Marc-André Lureau
2025-04-08 9:53 ` Dietmar Maurer [this message]
2025-04-08 10:37 ` Marc-André Lureau
2025-04-08 11:10 ` Dietmar Maurer
2025-04-07 10:59 ` [PATCH 3/3] vnc: h264: send additional frames after the display is clean Dietmar Maurer
2025-04-07 20:17 ` Marc-André Lureau
-- strict thread matches above, loose matches on Subject: below --
2025-04-08 7:15 [PATCH 0/3] Add VNC Open H.264 Encoding Dietmar Maurer
2025-04-08 7:15 ` [PATCH 2/3] add vnc h264 encoder Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1880642940.1156.1744105987725@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).